Date: Wed, 26 Apr 2000 12:19:42 +0200 (CEST) From: Remy Nonnenmacher <remy@boostworks.com> To: archie@whistle.com Cc: luigi@FreeBSD.ORG, csg@waterspout.com, pavel@alum.mit.edu, nsayer@sftw.com, julian@elischer.org, freebsd-net@FreeBSD.ORG Subject: Re: Proposal for ethernet, bridging, netgraph Message-ID: <200004261019.MAA43188@luxren2.boostworks.com> In-Reply-To: <200004260055.RAA55462@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Apr, Archie Cobbs wrote: > Archie Cobbs writes: >> OK, here's a patch ready for review & test.. this patch does one >> thing, which is move the calls to BPF and BRIDGE'ing out of each >> Ethernet driver and into ether_input(). > > Thanks for the input! The patch has been updated.. > > ftp://ftp.whistle.com/pub/archie/misc/net.cleanup.patch.2 > >..... Well but the tricky thing is the bdg_forward() function. As it may be called from the if_xx codes and from ether_output(), the work implied will be probably a lot more important than delaying the ether header ripping after the bridging in ether_input(). What about: 1) create an ether_input2() that {bpf_tap(), brige(), m_adj(); ether_input()} 2) Call ether_input2() from any simple drivers doing the ripping. 3) keep all 'strange' or not-reviewed drivers using the standard ether_input() 4) carefully move all these drivers needing review to ether_input2() 5) merge ether_input2 into ether_input when there will be no more driver using the standard ether_input. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004261019.MAA43188>