Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Mar 2017 08:15:59 +0000 (UTC)
From:      Boris Samorodov <bsam@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r436264 - head/graphics/iccexamin/files
Message-ID:  <201703160815.v2G8FxcB024705@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bsam
Date: Thu Mar 16 08:15:59 2017
New Revision: 436264
URL: https://svnweb.freebsd.org/changeset/ports/436264

Log:
  Fix build with clang-4.0. Error log:
  -----
  /wrkdirs/usr/ports/graphics/iccexamin/work/icc_examin-0.55/icc_profile_tags.cpp:352:28: error: ordered comparison between pointer and zero ('char *' and 'int')
      while (strchr(txt, 13) > 0) { // \r 013 0x0d
             ~~~~~~~~~~~~~~~ ^ ~
  /wrkdirs/usr/ports/graphics/iccexamin/work/icc_examin-0.55/icc_profile_tags.cpp:357:15: error: ordered comparison between pointer and zero ('char *' and 'int')
        if (pos > 0) {
            ~~~ ^ ~
  -----
  
  Reported by:	FreeBSD package builder

Added:
  head/graphics/iccexamin/files/patch-icc_profile_tags.cpp   (contents, props changed)

Added: head/graphics/iccexamin/files/patch-icc_profile_tags.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/iccexamin/files/patch-icc_profile_tags.cpp	Thu Mar 16 08:15:59 2017	(r436264)
@@ -0,0 +1,17 @@
+--- icc_profile_tags.cpp.orig	2017-03-15 08:21:33.000000000 +0000
++++ icc_profile_tags.cpp	2017-03-15 08:21:33.000000000 +0000
+@@ -349,12 +349,12 @@
+ #   ifdef DEBUG_ICCTAG
+     DBG_NUM_S ((int)strchr(txt, 13))
+ #   endif
+-    while (strchr(txt, 13) > 0) { // \r 013 0x0d
++    while (strchr(txt, 13)) { // \r 013 0x0d
+       pos = strchr(txt, 13);
+ #     ifdef DEBUG_ICCTAG
+       //cout << (int)pos << " "; DBG
+ #     endif
+-      if (pos > 0) {
++      if (pos) {
+         if (*(pos+1) == '\n')
+           *pos = ' ';
+         else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703160815.v2G8FxcB024705>