From owner-freebsd-ports Wed Jun 25 07:24:33 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id HAA25097 for ports-outgoing; Wed, 25 Jun 1997 07:24:33 -0700 (PDT) Received: from itojun.csl.sony.co.jp (root@itojun.csl.sony.co.jp [133.138.1.134]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA25088 for ; Wed, 25 Jun 1997 07:24:29 -0700 (PDT) From: itojun@itojun.org Received: from localhost (itojun@localhost [127.0.0.1]) by itojun.csl.sony.co.jp (8.8.5/3.3W3) with ESMTP id XAA13069; Wed, 25 Jun 1997 23:21:55 +0900 (JST) To: rssh@cki.ipri.kiev.ua Cc: ports@freebsd.org Subject: Re: about portlint X-Template-Reply-To: itojun@itojun.org X-Template-Return-Receipt-To: itojun@itojun.org X-PGP-Fingerprint: F8 24 B4 2C 8C 98 57 FD 90 5F B4 60 79 54 16 E2 References: <33B0D671.3A09@cki.ipri.kiev.ua> In-reply-to: Ruslan Shevchenko 's message of Wed, 25 Jun 1997 11:27:25 +0300. <33B0D671.3A09@cki.ipri.kiev.ua> X-Mailer: comp (MHng project) version 1997/04/30 02:23:09, by Jun-ichiro Itoh MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-ID: Date: Wed, 25 Jun 1997 23:21:49 +0900 Message-ID: <13066.867248509@itojun.csl.sony.co.jp> Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >> how's this? >> ftp://ftp.foretune.co.jp/pub/tools/portlint/portlint.pl-1.14 >1. As I can understand, you chack pathname in > PATHSITES, PATHFILES. >what if i have patch, living in directory >ftp.x.y/pub/usr/X11R6/lib/patch-for-foo ? >(of course, probability is low, but exists) I've added some rules to exclude URLs from the absolute pathname check. >2. How about checkpathname in all files from > scripts/* (--optional, with WARH) ? I'll try it, >No, it's I sorry. > It is my port: pr-3758. >You don't need to look at it, the matter, that the SR >have own configure script, in which prefix must be parameter. >then, in configure i seen the code in next style: > case $prefix in) > /opt) > ..... >So, i *must* to write an absolute pathname. >So, I want future, such as: >### ---portlint, do not look at next line--- ###. >PREFIX=/usr/local like /*NOTREACHED*/ or /*ARGSUSED*/ in real lint? mmm, that depends on how you interpret the warning from portlint. If you know what you are doing, I believe you can ignore what portlint warns you in the above case. portlint can never be a perfect parser for makefile/shell script/ whatever... (of course I'm trying to, but I have to make a compromise at some level) anyway thanks for the comments, I'll try to update soon. itojun