From owner-cvs-all Wed Oct 23 12:30:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8DD637B404 for ; Wed, 23 Oct 2002 12:30:53 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B22A43E3B for ; Wed, 23 Oct 2002 12:30:53 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 18049 invoked from network); 23 Oct 2002 19:30:53 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 23 Oct 2002 19:30:53 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9NJUon5068063; Wed, 23 Oct 2002 15:30:51 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200210231856.g9NIuIks095533@grimreaper.grondar.org> Date: Wed, 23 Oct 2002 15:30:54 -0400 (EDT) From: John Baldwin To: Mark Murray Subject: Re: cvs commit: src/include stdlib.h src/lib/libc/gen getbsize.3 Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Bruce Evans Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-Oct-2002 Mark Murray wrote: >> > Make the first argument of getbsize a size_t* instead of an int*, as this is what the >> > quantity actually is. Fix an easy const while I'm here. >> >> This breaks binary compatibility on 64-bit machines. > > So we perhaps need to bump ${MAJ}? We already have for 5.0. > Consumers of this interface == { df, du, ls, pkg_install, stat, pstat } > > Of the N (<12) calls to the function, 6 of them (one of 2 in df, stat, 3 > in pstat) actually use the returned value. Easy fixes (warnings only). > > I don't believe this is a crisis. Make world has fixed worse problems. Seriously, the only breakage from previous releases would be for people with Alphas running 4.x binaries but those should be using either libc.so.4 or be statically linked so it's no big deal. People in -current can just deal I guess since that is current. We break the ABI in current a lot as it is. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message