Date: Mon, 24 Nov 2008 17:40:04 GMT From: Sam Leffler <sam@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 153447 for review Message-ID: <200811241740.mAOHe4X5044437@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=153447 Change 153447 by sam@sam_ebb on 2008/11/24 17:39:57 o move check to where it's needed o style Affected files ... .. //depot/projects/arp-v2/src/sys/netinet/if_ether.c#17 edit Differences ... ==== //depot/projects/arp-v2/src/sys/netinet/if_ether.c#17 (text+ko) ==== @@ -198,10 +198,10 @@ SIN(ifa->ifa_netmask)->sin_addr.s_addr) ) break; /* found it. */ } - } - if (sip == NULL) { - printf(" cannot find matching address, no arprequest\n"); - return; + if (sip == NULL) { + printf("%s: cannot find matching address\n", __func__); + return; + } } if ((m = m_gethdr(M_DONTWAIT, MT_DATA)) == NULL) @@ -226,8 +226,6 @@ sa.sa_len = 2; m->m_flags |= M_BCAST; (*ifp->if_output)(ifp, m, &sa, (struct rtentry *)0); - - return; } /* @@ -255,7 +253,7 @@ *lle = NULL; - if (m) { + if (m != NULL) { if (m->m_flags & M_BCAST) { /* broadcast */ (void)memcpy(desten,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811241740.mAOHe4X5044437>