From owner-cvs-all  Sun Jun  9 17:49:57 2002
Delivered-To: cvs-all@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 68A8637B407; Sun,  9 Jun 2002 17:49:53 -0700 (PDT)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.3/8.12.3) with ESMTP id g5A0nrCV004847;
	Sun, 9 Jun 2002 17:49:53 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.3/8.12.3/Submit) id g5A0nr1P004846;
	Sun, 9 Jun 2002 17:49:53 -0700 (PDT)
	(envelope-from dillon)
Date: Sun, 9 Jun 2002 17:49:53 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200206100049.g5A0nr1P004846@apollo.backplane.com>
To: "Greg 'groggy' Lehey" <grog@FreeBSD.ORG>
Cc: Mike Barcroft <mike@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/include pwd.h
References: <200206091939.g59JdJC05285@freefall.freebsd.org> <20020610004026.GD61036@wantadilla.lemis.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


:>   Log:
:>   o Remove include of <sys/types.h>, it adds too much pollution;
:>     instead, add typedefs of only gid_t, time_t, and uid_t.
:
:Isn't this contrary to the intentions of header files?  What happens
:if one of these types changes?
:
:Greg
:--
:See complete headers for address and phone numbers

    And why is it conditional on _BSD_XXX_T being defined?  Either
    pwd.h and password related routines need these types or they don't.
    If they don't need them then the typedefs do not belong in pwd.h.
    If they do need them then either the users must #include the properly
    header file, or <pwd.h> must #include the proper header file.  You
    don't want a 'some times it does this, sometimes it does that' type
    of situation.

    The manual pages seem fairly clear.  If you look at something like
    'man getgid' it clearly states that <sys/types.h> must be included
    before <unistd.h>.

    For password related calls, the manual page also quite clearly states
    that <sys/types.h> must be included before <pwd.h>

    For these reasons I would strongly recommend either reverting this change
    and leaving at as it was, or removing <sys/types.h> from <pwd.h>
    and *NOT* adding weird #ifdef's for gid_t, uid_t, etc, as the manual
    page implies.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message