Date: Wed, 15 Sep 2021 22:34:02 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 230996] em/igb: Intel i210/i350: ifconfig: enabling "vlanhwtag" renders VLAN on i210/i350 NICs unusable Message-ID: <bug-230996-7501-8nhmK82iG0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230996-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-230996-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230996 --- Comment #36 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2796f7cab10785ef40efbba97ef67ab31= 9c96e9c commit 2796f7cab10785ef40efbba97ef67ab319c96e9c Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2021-09-15 14:47:19 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-09-15 15:03:01 +0000 e1000: Fix up HW vlan ops * Don't reset the entire adapter for vlan changes, fix up the problems * Add some functions for vlan filter (vfta) manipulation * Don't muck with the vfta if we aren't doing HW vlan filtering * Disable interrupts when manipulating vfta on lem(4)-class NICs * On the I350 there is a specification update (2.4.20) in which the suggested workaround is to write to the vfta 10 times (if at first you don't succeed, try, try again). Our shared code has the goods, use it * Increase a VF's frame receive size in the case of vlans From the referenced PR, this reduced vlan configuration from minutes to seconds with hundreds or thousands of vlans and prevents wedging the adapter with needless adapter reinitialization for each vlan ID. PR: 230996 Reviewed by: markj Tested by: Ozkan KIRIK <ozkan.kirik@gmail.com> MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D30002 sys/dev/e1000/if_em.c | 166 ++++++++++++++++++++++++++++++++++++++--------= ---- 1 file changed, 126 insertions(+), 40 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230996-7501-8nhmK82iG0>