From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue May 14 21:00:02 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 3CCD151C
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Tue, 14 May 2013 21:00:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 2FAEBCB1
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Tue, 14 May 2013 21:00:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4EL02GD037116
 for <freebsd-ports-bugs@freefall.freebsd.org>; Tue, 14 May 2013 21:00:02 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4EL02ux037115;
 Tue, 14 May 2013 21:00:02 GMT (envelope-from gnats)
Date: Tue, 14 May 2013 21:00:02 GMT
Message-Id: <201305142100.r4EL02ux037115@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2013 21:00:02 -0000

The following reply was made to PR ports/177857; it has been noted by GNATS.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: Kevin Zheng <kevinz5000@gmail.com>
Cc: bug-followup@FreeBSD.org,  Henry Hu <henry.hu.sh@gmail.com>
Subject: Re: ports/177857: [patch] Update x11/slim to 1.3.5
Date: Tue, 14 May 2013 23:55:20 +0300

 Kevin Zheng <kevinz5000@gmail.com> writes:
 
 > Oops, it looks like I forgot to send the latest patch to GNATS. You can
 > find it attached here now.
 
 Thanks, a few comments below.
 
 >  LICENSE=	GPLv2
 > +LICENSE_FILE=	${WRKSRC}/COPYING
 
 This shouldn't be needed. Standard licenses such as GPLv2 already have a
 copy in Templates/Licenses.
 
 >  USES=		cmake pkgconfig
 > +USE_RC_SUBR=	slim
 >  USE_XORG=	ice sm x11 xau xdmcp xext xft xmu xorg-server xrender xt
 > -USE_RC_SUBR=	slim
 >  SUB_FILES=	pkg-message
 
 Is there a reason for this change other than ordering the "USE_"
 variables alphabetically? Otherwise it just makes svn blaming more
 difficult.
 
 >  .	if ${PORT_OPTIONS:MPAM}
 > +	@${MKDIR} ${PREFIX}/etc/pam.d
 
 You shouldn't need to do this, ${PREFIX}/etc/pam.d is part of the
 standard directories defined in Templates/BSD.local.dist.