From owner-cvs-all Sat Aug 24 11:22:39 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 231E537B400; Sat, 24 Aug 2002 11:22:34 -0700 (PDT) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by mx1.FreeBSD.org (Postfix) with ESMTP id 061B843E6A; Sat, 24 Aug 2002 11:22:32 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.12.5/8.12.2) with ESMTP id g7OIMOmU021690; Sat, 24 Aug 2002 20:22:25 +0200 (CEST) (envelope-from wkb@freebie.xs4all.nl) Received: (from wkb@localhost) by freebie.xs4all.nl (8.12.5/8.12.5/Submit) id g7OIMOd5021689; Sat, 24 Aug 2002 20:22:24 +0200 (CEST) Date: Sat, 24 Aug 2002 20:22:24 +0200 From: Wilko Bulte To: John Polstra Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/net rcmd.c Message-ID: <20020824202224.A21671@freebie.xs4all.nl> References: <200208241737.g7OHbgNV063820@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200208241737.g7OHbgNV063820@freefall.freebsd.org>; from jdp@FreeBSD.ORG on Sat, Aug 24, 2002 at 10:37:42AM -0700 X-OS: FreeBSD 4.6-STABLE X-PGP: finger wilko@freebsd.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Aug 24, 2002 at 10:37:42AM -0700, John Polstra wrote: > jdp 2002/08/24 10:37:42 PDT > > Modified files: > lib/libc/net rcmd.c > Log: > Fix a bug in __ivaliduser_sa() which caused some rsh/rlogin attempts > to fail needlessly if a reverse DNS lookup of the IP address didn't > come up with a hostname. As a comment in the code clearly stated, > the "damn hostname" was looked up only for the purpose of netgroup > matching. But if that lookup failed, the function bailed out > immediately even though in many cases netgroup matching would not > be used. > > This change marks the hostname as unknown but continues. Where > netgroup matching is performed, an unknown hostname is handled > conservatively. I.e., for "+@netgroup" (accept) entries an unknown > hostname never matches, and for "-@netgroup" (reject) entries an > unknown hostname always matches. > > In the lines affected (only), I also fixed a few bogus casts. There > are others, and in fact this entire file would be a good candidate > for a cleanup sweep. > > Reviewed by: imp (wearing his flourescent yellow Security Team cap) Can we have a photograph of that fluorescent etc please? -- | / o / /_ _ wilko@FreeBSD.org |/|/ / / /( (_) Bulte Arnhem, the Netherlands To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message