From owner-freebsd-fs Sat May 30 20:27:54 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA21955 for freebsd-fs-outgoing; Sat, 30 May 1998 20:27:54 -0700 (PDT) (envelope-from owner-freebsd-fs@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA21937 for ; Sat, 30 May 1998 20:27:50 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id DAA20959; Sun, 31 May 1998 03:27:42 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id FAA10219; Sun, 31 May 1998 05:27:19 +0200 (MET DST) Message-ID: <19980531052719.31196@follo.net> Date: Sun, 31 May 1998 05:27:19 +0200 From: Eivind Eklund To: Bruce Evans , fs@FreeBSD.ORG Subject: Re: componentnames to VOPs References: <199805310242.MAA28948@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199805310242.MAA28948@godzilla.zeta.org.au>; from Bruce Evans on Sun, May 31, 1998 at 12:42:38PM +1000 Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sun, May 31, 1998 at 12:42:38PM +1000, Bruce Evans wrote: > >Is there any documentation as to whether these should be locked by > >namei() or not? > > vnodes are locked by namei() according to the LOCKPARENT and LOCKLEAF > flags. I don't know what you mean by locking a componentname. If > the parent isn't locked, then the information in the componentname > may become stale. Mostly you don't care. I'm changing vput() to taking process as a parameter, partially to fix some problems where curproc is stale. Michael Hancock said it would be certain to be correct to use cnp->cn_proc only in the cases where the vnode is locked by namei() - but how do I know for parameters to VOP_XXX()? I can find out that it is correct right now farily easily, but the new requirement should probably be documented somewhere. Where do I put documentation for this requirement? Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message