From owner-freebsd-ports@FreeBSD.ORG Mon Jul 28 05:49:39 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2620137B401; Mon, 28 Jul 2003 05:49:39 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-63-207-60-135.dsl.lsan03.pacbell.net [63.207.60.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA3A643FA3; Mon, 28 Jul 2003 05:49:35 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id BAD5666D6A; Mon, 28 Jul 2003 05:49:27 -0700 (PDT) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 8B0EEC38; Mon, 28 Jul 2003 05:49:27 -0700 (PDT) Date: Mon, 28 Jul 2003 05:49:27 -0700 From: Kris Kennaway To: Jens Rehsack Message-ID: <20030728124927.GA27827@rot13.obsecurity.org> References: <200307272105.h6RL5BTo000730@helo.liwing.de> <20030727221222.GA93833@huckfinn.arved.de> <20030728114351.GA53070@rot13.obsecurity.org> <3F25126C.4030501@liwing.de> <20030728121703.GA63021@rot13.obsecurity.org> <3F25192B.1090502@liwing.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F25192B.1090502@liwing.de> User-Agent: Mutt/1.4.1i cc: ports@FreeBSD.org cc: Tilman Linneweh cc: freebsd-gnats-submit@FreeBSD.org cc: Kris Kennaway Subject: Re: ports/36112: [PATCH] New feature for whole ports tree: GS_PORT variable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2003 12:49:39 -0000 On Mon, Jul 28, 2003 at 02:38:03PM +0200, Jens Rehsack wrote: > I mean that I see the requirement of checking for -nox11, but I > don't want to introduce it overall, because I see that the > configure scripts of mail/courier and graphics/ImageMagic check > for it separately. So I wanted to hear what the port experts say > to that problem. That's not really a problem; ports that have their own optional X11 dependencies can (and should) have their WITHOUT_X11 checks to disable this, but there's no need for it to also add -nox11 to the ghostscript port. The use would just set WITHOUT_X11=foo to turn off x11 support in ImageMagick, and GHOSTSCRIPT_PORT=print/ghostscript-gnu-x11 to make it depend on a non-X11 ghostscript variant. > >What would such a bsd.ghostscript.mk contain? > > Not much, just a check for the right ghostscript-port (gnu/afpl, > (-nox11){0,1}). And maybe some common things from > ghostscript-*/Makefile (must be checked before). Unless there's something substantial to be done, there's not a big reason to break it out of bsd.port.mk into its own makefile. Kris