Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 Nov 2016 12:21:35 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 214638] devel/kore: fails to build on 12.0
Message-ID:  <bug-214638-13-pMtYnbft5k@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-214638-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-214638-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214638

Tobias Kortkamp <t@tobik.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177182|                            |maintainer-approval+
              Flags|                            |

--- Comment #3 from Tobias Kortkamp <t@tobik.me> ---
Created attachment 177182
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D177182&action=
=3Dedit
kore.diff

I currently see three ways to fix this, but I'm unsure which one is the
correct one:

(1) Add #undef basename to src/cli.c, so that it always uses the new
    basename without having to use _Generic

(2) Add -Wno-error=3Dc11-extensions to CFLAGS.  This breaks the build
    with gcc (since it doesn't know about -Wno-error) and on FreeBSD 9.3,
    but at least we don't just silence the warning.  Building on FreeBSD
    9.3 could be fixed by building with clang from ports, but I'm more
    inclined to just mark it broken.

(3) Use -std=3Dc11 instead of -std=3Dc99.  I'm unsure what -std=3Dc11
    actually implies, probably more than just -Wno-c11-extensions.

I'm leaning towards (2) and the patch is for that approach.  It should also=
 fix
building with clang 3.9 (bug #214639).

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-214638-13-pMtYnbft5k>