Date: Thu, 03 Feb 2022 20:50:16 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261637] www/rubygem-gollum: Remove unused dependencies Message-ID: <bug-261637-7788-xlcqGeZB2E@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-261637-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-261637-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261637 --- Comment #3 from Sir l33tname <sirl33tname@gmail.com> --- Thanks for the feedback! > What are the failure modes / effects, if any Does not affect quarterly i guess since the changes are new. For latest it means you can not use www/rubygem-gollum-lib as standalone. (I don't think that is a use-case since the lib has a very strong coupling = to www/rubygem-gollum) I broke that here: - https://cgit.freebsd.org/ports/commit/?id=3D644d2ef109a340cdf0d19561117db3d= 9e63b52f7 - https://cgit.freebsd.org/ports/commit/?id=3Dfef2fa5fd8a2a9e170be66133e9d535= a9bc6fd4b The default adapter changes with the update from www/rubygem-gollum-grit_adapter10 to www/rubygem-gollum-rugged_adapter and i added it to the wrong port. > Does gollum-lib pass its test suite after patching dependency version spe= c? [1] bundle exec rake test /usr/local/bin/ruby27 -I"lib:lib:test:." /usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3/vendor/ruby/2.7/gem= s/rake-13.0.6/lib/rake/rake_test_loader.rb=20 root@freebsd:/usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3 # echo= $? 0 I guess yeah also i already use this in my local setup and i guess it works. > Could you confirm QA (portlint, poudriere) for these changes www/rubygem-gollum # portlint WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "USES". 0 fatal errors and 1 warning found. /www/rubygem-gollum-lib # portlint=20 looks fine not sure about the first warning tried to fix it but when i move USES over = the RUN_DEPENDS section i get an other warning. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-261637-7788-xlcqGeZB2E>