Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Apr 2017 17:13:00 +0000 (UTC)
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r316365 - stable/11/sys/fs/devfs
Message-ID:  <201704011713.v31HD0iN079433@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: trasz
Date: Sat Apr  1 17:13:00 2017
New Revision: 316365
URL: https://svnweb.freebsd.org/changeset/base/316365

Log:
  MFC r313994:
  
  Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf.
  It's not a proper fix, but should be better than what we have now.
  Since it got broken some six months ago it results in an incredibly
  annoying and trivially reproducible panic every time eg an USB disk
  gets disconnected.
  
  Sponsored by:	DARPA, AFRL

Modified:
  stable/11/sys/fs/devfs/devfs_vnops.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/fs/devfs/devfs_vnops.c
==============================================================================
--- stable/11/sys/fs/devfs/devfs_vnops.c	Sat Apr  1 17:09:55 2017	(r316364)
+++ stable/11/sys/fs/devfs/devfs_vnops.c	Sat Apr  1 17:13:00 2017	(r316365)
@@ -693,7 +693,7 @@ devfs_fsync(struct vop_fsync_args *ap)
 
 			error = vop_stdfsync(ap);
 			if (bo->bo_dirty.bv_cnt != 0 || error != 0)
-				panic("devfs_fsync: vop_stdfsync failed.");
+				printf("devfs_fsync: vop_stdfsync failed.");
 		}
 
 		return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704011713.v31HD0iN079433>