From owner-freebsd-ports  Tue Aug 10  2:10: 8 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id EA23A153B3
	for <freebsd-ports@FreeBSD.org>; Tue, 10 Aug 1999 02:10:05 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id CAA15918;
	Tue, 10 Aug 1999 02:10:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from rucus.ru.ac.za (rucus.ru.ac.za [146.231.29.2])
	by hub.freebsd.org (Postfix) with SMTP id 7991515397
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 1999 02:04:11 -0700 (PDT)
	(envelope-from nbm@rucus.ru.ac.za)
Received: (qmail 25905 invoked by uid 1003); 10 Aug 1999 09:04:33 -0000
Message-Id: <19990810090433.25904.qmail@rucus.ru.ac.za>
Date: 10 Aug 1999 09:04:33 -0000
From: nbm@rucus.ru.ac.za
Reply-To: nbm@rucus.ru.ac.za
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/13056: apache13-php3 doesn't give versions for php3, and incorrect versioning with modssl
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         13056
>Category:       ports
>Synopsis:       apache13-php3 doesn't give versions for php3, and incorrect versioning with modssl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 10 02:10:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Neil Blakey-Milner
>Release:        FreeBSD 3.0-STABLE i386
>Organization:
Rhodes University Computer Users' Society
>Environment:

FreeBSD rucus.ru.ac.za 3.0-STABLE FreeBSD 3.0-STABLE #0: Tue Feb  9 22:52:23 GMT 1999     grahams@rucus.ru.ac.za:/usr/src/sys/compile/RUCUS-SMP  i386

>Description:

Firstly, the version of php3 isn't given in the package name, which makes
it possible for it to seem that the port doesn't have a new version, and
thus fool programs like pkg_version.

Secondly, when modssl is specified in configure.php3, the package name is
messed up by using app-version+app-version format, which is incorrect, as
evidenced by changes in apache13-modssl.

In both cases, apache13-modssl gives a good example of what is required.

>How-To-Repeat:

cd /usr/ports/www/apache13-php3 && make packagename

>Fix:
--- Makefile.orig	Tue Aug 10 10:56:24 1999
+++ Makefile	Tue Aug 10 10:56:44 1999
@@ -7,7 +7,7 @@
 #
 
 DISTNAME=	apache_${VERSION_APACHE}
-PKGNAME=	apache-php3-${VERSION_APACHE}
+PKGNAME=	apache-php3-${VERSION_APACHE}+${VERSION_PHP3}
 CATEGORIES=	www
 MASTER_SITES=	http://www.apache.org/dist/ \
 		http://www.rge.com/pub/infosystems/apache/dist/ \
--- scripts/configure.php.orig	Tue Aug 10 10:57:00 1999
+++ scripts/configure.php	Tue Aug 10 10:58:48 1999
@@ -107,7 +107,7 @@
 			;;
 		\"modssl\")
 			cat << EOF
-PKGNAME=	apache-php3-\${VERSION_APACHE}+mod_ssl-\${VERSION_MODSSL}
+PKGNAME=	apache-php3-mod_ssl-\${VERSION_APACHE}+\${VERSION_PHP3}+\${VERSION_MODSSL}
 MASTER_SITES+=	http://www.modssl.org/source/ \\
 		ftp://ftp.modssl.org/source/ \\
 		ftp://ftp.ecrc.net/pub/security/mod_ssl/ \\

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message