From owner-cvs-all@FreeBSD.ORG  Wed Mar 31 22:42:47 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B090116A4CE; Wed, 31 Mar 2004 22:42:47 -0800 (PST)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AFAA643D2F; Wed, 31 Mar 2004 22:42:46 -0800 (PST)
	(envelope-from ru@ip.net.ua)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i316k99x019158
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 1 Apr 2004 09:46:10 +0300 (EEST)
	(envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.12.11/8.12.11) id i316gfiG018704;
	Thu, 1 Apr 2004 09:42:41 +0300 (EEST)
	(envelope-from ru)
Date: Thu, 1 Apr 2004 09:42:41 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20040401064241.GA18644@ip.net.ua>
References: <20040331211028.37B5016A4E2@hub.freebsd.org>
	<20040331134609.N90425@root.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk"
Content-Disposition: inline
In-Reply-To: <20040331134609.N90425@root.org>
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_ste.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2004 06:42:47 -0000


--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote:
> On Wed, 31 Mar 2004, Ruslan Ermilov wrote:
> >   Modified files:
> >     sys/pci              if_ste.c
> >   Log:
> >   Under a heavy RX load, at least with D-Link DFE-550TX adapters,
> >   the driver's RX ring head may fall behind the chip, causing the
> >   stuck traffic, disordered packets, etc.  Work around this by
> >   adopting the technique of resyncing RX head used in dc(4) and
> >   xl(4) drivers, but do it in a slightly different place to reduce
> >   the number of resyncs needed.
> >
> >   Also, set the NIC's RX polling period to a more meaningful value,
> >   to stop overloading the PCI bus (this also reduces the number of
> >   resyncs by a factor of 3 or more in a long run; the actual number
> >   is very dependent on a nature of the traffic).
> >
> >   Maintain the statistics counter as the hw.ste_rxsyncs sysctl.
>=20
> This pollutes the toplevel hw sysctl space.  Please move it to
> hw.ste.rxsyncs or better, debug.*.
>=20
Seems I followed the bad practice from dc(4) and fxp(4).  I will
move it to hw.ste, thanks.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAa7nhUkv4P6juNwoRArzIAJ0c11E8P60wzWASTOOPmP5Na6FJWgCfXkG4
7saHHYDAxKv7qZipPK8WTy0=
=l2Rs
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--