From owner-freebsd-stable@FreeBSD.ORG Mon Sep 25 17:50:19 2006 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0158516A40F for ; Mon, 25 Sep 2006 17:50:19 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DF6D43D58 for ; Mon, 25 Sep 2006 17:50:17 +0000 (GMT) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.13.8/8.13.6) with ESMTP id k8PHoGSw006801; Mon, 25 Sep 2006 21:50:16 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Mon, 25 Sep 2006 21:50:16 +0400 (MSD) From: Dmitry Morozovsky To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= In-Reply-To: <868xk8tjfy.fsf@dwp.des.no> Message-ID: <20060925214730.R752@woozle.rinet.ru> References: <20060925114102.F79983@woozle.rinet.ru> <868xk8tjfy.fsf@dwp.des.no> X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (woozle.rinet.ru [0.0.0.0]); Mon, 25 Sep 2006 21:50:16 +0400 (MSD) Cc: stable@freebsd.org Subject: Re: chpass(1) patch for changing only crypted passwords X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2006 17:50:19 -0000 On Mon, 25 Sep 2006, Dag-Erling Sm?rgrav wrote: DS> Dmitry Morozovsky writes: DS> > chpass is a bit broken since chpass.c:1.23 - it uses pw_equal which DS> > does not check crypted password field; so, you can not change _only_ DS> > crypt pass with chpass. Attached patch fixes this. DS> DS> Looks fine to me, feel free to commit. Done, thanks. BTW, a question inspired by ru@: why pw_equal() skips password field? Its interface is unpublished, and the only consumers are marck@woozle:/lh/src.current> grep -Rl pw_equal . ./lib/libutil/libutil.h ./lib/libutil/pw_util.c ./release/picobsd/tinyware/passwd/pw_copy.c ./usr.bin/chpass/chpass.c and tyniware is false alarm ;) Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------