From owner-svn-src-all@FreeBSD.ORG Thu May 5 23:00:50 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBE63106566B; Thu, 5 May 2011 23:00:50 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 25E6A8FC16; Thu, 5 May 2011 23:00:49 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEANoqw02DaFvO/2dsb2JhbACEUKJliHKrXpEngSqDXIEBBI9KhxqHUQ X-IronPort-AV: E=Sophos;i="4.64,323,1301889600"; d="scan'208";a="119782146" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 05 May 2011 19:00:49 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 1B95EB3F5A; Thu, 5 May 2011 19:00:49 -0400 (EDT) Date: Thu, 5 May 2011 19:00:49 -0400 (EDT) From: Rick Macklem To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Message-ID: <134917667.1082867.1304636449048.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <86r58dqett.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.203] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692) Cc: svn-src-head@freebsd.org, Rick Macklem , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221124 - in head: . sbin/mount sbin/mount_nfs sys/amd64/conf sys/fs/nfsclient sys/i386/conf sys/ia64/conf sys/nfsclient sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 23:00:50 -0000 > Rick Macklem writes: > > Well, another way it could be handled would be to put the sysctls > > and > > the global variables they manipulate in a module shared by both > > clients, > > like sys/nfs/nfs_lock.c (module "nfslock"). Then the same sysctl > > would > > affect both clients. (I hesitate to create "yet another" module just > > to share the sysctls, but since "nfslock" is used by both clients, > > it > > should work ok, I think.) > > I don't understand why you would want to do that. Can't you just > change > "oldnfs" back to "nfs" in the old stack? > I'm not sure what you are saying. W.r.t. the SYSCTL() naming, the old NFS client is currently using vfs.nfs.xxx and the new NFS client is using vfs.newnfs.xxx. If you are referring to the fstype names, then switching "oldnfs" back to "nfs" means the new one has to change to something other than "nfs", like "newnfs". The whole idea of changing "newnfs"->"nfs" was to make it the default and get it more widely tested/used. (Presumably, if the new NFS works well, it would eventually become the only one, but I don't see that happening until FreeBSD10 at the earliest.) The problem is w.r.t. the SYSCTL() naming. I could make vfs.newnfs.xxx use vfs.nfs.xxx and vfs.nfs.xxx->vfs.oldnfs.xxx quite easily. The problem would be that people couldn't as easily use "oldnfs" instead of "nfs". (At least for cases where setting sysctls matter.) What I was proposing is have the two clients share the vfs.nfs.xxx name space, since most of the SYSCTL()s use the same name and do the same thing. For example, now there is: vfs.nfs.bufpackets: 4 vfs.newnfs.bufpackets: 4 and /etc/rc.d/nfsclient wants to fiddle with vfs.nfs.bufpackets. I was proposing that the two clients share vfs.nfs.bufpackets Make sense now? (I understood that you felt having both vfs.nfs.xxx and vfs.newnfs.xxx made maintaining the scripts awkward.) rick