From owner-cvs-all Sun Feb 25 15:42: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 9696D37B4EC; Sun, 25 Feb 2001 15:41:56 -0800 (PST) (envelope-from imp@billy-club.village.org) Received: from billy-club.village.org (billy-club.village.org [10.0.0.3]) by rover.village.org (8.11.2/8.11.0) with ESMTP id f1PNfth85124; Sun, 25 Feb 2001 16:41:55 -0700 (MST) (envelope-from imp@billy-club.village.org) Received: from billy-club.village.org (localhost [127.0.0.1]) by billy-club.village.org (8.11.2/8.8.3) with ESMTP id f1PNd1Y01249; Sun, 25 Feb 2001 16:39:01 -0700 (MST) Message-Id: <200102252339.f1PNd1Y01249@billy-club.village.org> To: Gary Jennejohn Subject: Re: cvs commit: src/usr.sbin/pccard/pccardd util.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sun, 25 Feb 2001 11:52:43 PST." <200102251952.f1PJqhe95166@freefall.freebsd.org> References: <200102251952.f1PJqhe95166@freefall.freebsd.org> Date: Sun, 25 Feb 2001 16:39:01 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200102251952.f1PJqhe95166@freefall.freebsd.org> Gary Jennejohn writes: : Use vsnprintf in logmsg() to avoid overflowing the array on the stack. : The problem was noted with an older model 3Com 3C589 which seems : to return more than 256 bytes of data. The fix is a good one, but the explaination doesn't make sense to be because CIS tuples are limited to 254 bytes... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message