Date: Wed, 30 Nov 2005 20:40:40 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/vinum geom_vinum_drive.c src/sys/geom/label g_label_iso9660.c g_label_msdosfs.c g_label_ufs.c src/sys/geom/raid3 g_raid3.c src/sys/geom/uzip g_uzip.c src/sys/geom/eli g_eli.c src/sys/geom ... Message-ID: <20051130194039.GI79912@garage.freebsd.pl> In-Reply-To: <200511301924.jAUJOpHL061333@repoman.freebsd.org> References: <200511301924.jAUJOpHL061333@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--37nyS7qXrnu4wN2o Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 30, 2005 at 07:24:51PM +0000, Maxim Sobolev wrote: +> sobomax 2005-11-30 19:24:51 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/geom/mirror g_mirror.c=20 +> sys/geom/vinum geom_vinum_drive.c=20 +> sys/geom/label g_label_ufs.c g_label_iso9660.c=20 +> g_label_msdosfs.c=20 +> sys/geom/raid3 g_raid3.c=20 +> sys/geom/uzip g_uzip.c=20 +> sys/geom/eli g_eli.c=20 +> sys/geom geom_aes.c geom_apple.c geom_bsd.c=20 +> geom_fox.c geom_gpt.c geom_mbr.c=20 +> geom_pc98.c geom_sunlabel.c=20 +> geom_vol_ffs.c=20 +> Log: +> Check for g_read_data(9) errors properly: +> =20 +> o The only indication of error condition is NULL value returned by +> the function; +> =20 +> o value pointed to by error argument is undefined in the case when +> operation completes successfully. If you decided to clean this up, please make it a complete clean-up, so noone has to clean up after you:) The thing I'm talking about is that when you don't plan to use error value, you can just pass NULL as the last argument for g_read_data(9). There are probably few places now where 'error' variable is unused. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --37nyS7qXrnu4wN2o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDjgA3ForvXbEpPzQRAvVEAKDAT3oerbJybZE3i1PpknKPOO0OrQCdGrs5 2Hqjp4KRhLJW969YvGFuzUM= =WeCu -----END PGP SIGNATURE----- --37nyS7qXrnu4wN2o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051130194039.GI79912>