From owner-freebsd-mobile Thu Sep 12 13:53:20 2002 Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D653C37B400 for ; Thu, 12 Sep 2002 13:53:17 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7090A43E42 for ; Thu, 12 Sep 2002 13:53:17 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 32156 invoked from network); 12 Sep 2002 20:53:13 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 12 Sep 2002 20:53:13 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8CKrEBv040095; Thu, 12 Sep 2002 16:53:14 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020912203302.GA1520@laptop.6bone.nl> Date: Thu, 12 Sep 2002 16:53:15 -0400 (EDT) From: John Baldwin To: Mark Santcroos Subject: Re: pccard re-attach after ACPI S1 resume Cc: mobile@FreeBSD.ORG Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 12-Sep-2002 Mark Santcroos wrote: > Hi John, > > On Thu, Sep 12, 2002 at 01:25:05PM -0400, John Baldwin wrote: >> > + sc->suspended = 0; /* XXX initialize, maybe not here */ >> > + >> > /* >> > * this is here so that when socket_enable calls gettype, trt happens >> > */ >> >> This part you don't need because softc's are zero'd when they are allocated. > > Ok. But still I need it for the reason below. > >> What if you just had pccard_resume() always call pccard_attach_card(self), >> does that work? > > Then we do an attach on a slot where we know there isn't anything anyway. > That basicly doesn't make sense, and it also spits out all kind of ulgy > messages that we don't want/need. We do a detach when we don't know if something is there in pccard_suspend(). :) Maybe pccard_attach_card() could take an argument to tell it to not whine if there is no card there. > Btw, is this problem specific to me or is just nobody using/reporting this? > It would seem like a generic problem. No, I see it too. I just don't suspend very often with pccards in my laptop. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message