Date: Tue, 11 Aug 2015 16:07:06 +0000 From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 201273] multimedia/openh264 fails to build on armv6 Message-ID: <bug-201273-21738-TqX5U010h7@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-201273-21738@https.bugs.freebsd.org/bugzilla/> References: <bug-201273-21738@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D201273 --- Comment #1 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 158258 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D158258 armv6 fix >--- Makefile (revision 390884) >+++ Makefile (working copy) >@@ -44,8 +44,12 @@ >=20 > .include <bsd.port.options.mk> >=20 >+.if ${ARCH} =3D=3D "armv6" >+CFLAGS+=3D -no-integrated-as What is this for? All *.S files are conditionalized by HAVE_NEON. Not to mention the flag is Clang-specific, so would break GCC build. >+.endif >+ > .if ! ${PORT_OPTIONS:MDEBUG} >-. if ${ARCH} =3D=3D amd64 || ${ARCH} =3D=3D arm || ${ARCH} =3D=3D i386 >+. if ${ARCH} =3D=3D amd64 || ${ARCH} =3D=3D arm || ${ARCH} =3D=3D armv6 |= | ${ARCH} =3D=3D i386 My fault. nasm is only used on x86. arm and arm64 use cc(1). I'll remove arm from there to avoid confusion. > BUILD_DEPENDS+=3D nasm:${PORTSDIR}/devel/nasm > . endif > .endif > >--- files/patch-build_arch.mk (revision 0) >+++ files/patch-build_arch.mk (working copy) >@@ -0,0 +1,10 @@ >+--- build/arch.mk.orig 2015-07-01 17:00:32 UTC >++++ build/arch.mk >+@@ -5,7 +5,6 @@ ifneq ($(filter-out arm64, $(filter arm% >+ ifeq ($(USE_ASM), Yes) >+ ASM_ARCH =3D arm >+ ASMFLAGS +=3D -I$(SRC_PATH)codec/common/arm/ >+-CFLAGS +=3D -DHAVE_NEON Does FreeBSD not support NEON at all or only on armv6? If the latter try replacing ifneq ($(filter-out arm64, $(filter arm%, $(ARCH))),) with ifneq ($(filter-out armv6 arm64, $(filter arm%, $(ARCH))),) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201273-21738-TqX5U010h7>