Date: Sun, 22 Mar 2015 10:40:05 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: Michael Grimm <trashcan@odo.in-berlin.de>, freebsd-ports@freebsd.org Subject: Re: net/unison240 depends on lang/ocaml-nox11 Message-ID: <550E8DF5.1020708@FreeBSD.org> In-Reply-To: <E2699E03-C171-4D0B-A7C3-CA87D8D9FAD0@odo.in-berlin.de> References: <CAGSa5y3KPuEsGHPztA4k_ejfvHnREMHysynHY%2B4ephA44rw-bg@mail.gmail.com> <CAGSa5y1ye0tAkF3Yjcd4yHA1_RjZxW025PaK3pexMChVW0c3eg@mail.gmail.com> <550D4CA0.8000606@sorbs.net> <550D61BF.3030403@FreeBSD.org> <550D636B.5020000@sorbs.net> <550D6D0F.7080401@FreeBSD.org> <550D7726.1060704@sorbs.net> <550D853C.7070303@FreeBSD.org> <A2C3ACF2-0391-4B16-A552-C9934020B0FD@odo.in-berlin.de> <550DB3FD.7070006@madpilot.net> <E2699E03-C171-4D0B-A7C3-CA87D8D9FAD0@odo.in-berlin.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/21/15 21:53, Michael Grimm wrote: > On 21.03.2015, at 19:10, Guido Falsi <mad@madpilot.net> wrote: >> On 03/21/15 17:55, Michael Grimm wrote: > >>> I recently (after last upgrade of poudriere-devel, although I do not know if that is the cause) ran into a comparable issue with unison without X11 : >>> >>> | MWN> cat /usr/local/etc/poudriere.d/stable10-make.conf >>> | WITHOUT_X11=yes >>> [...] >> >> I don't think old style WITH_/WITHOUT_ flags are supported anymore. >> Looking at the code you should in fact get a warning about this. > > Hmm, not that I am aware of. But I will have a closer look. But! Commenting that "WITHOUT_X11=yes" has been recognized by poudriere: the unison-nox11 port could be compiled successfully with default ocaml settings. > It is still working because there a re a few special cases which still need to be supported, but the general WITH_/WITHOUT aren't supported and the code making them work can be removed anytime. >>> That's weird, ocaml-nox11 defaults to "TK=on" which requires X11 support. Bug or feature? >> >> You sure you have no option directory with per port options enabling TK? > > Yes, I'm sure that I haven't had an option directory with per port options en/disabling TK set. > >> Options activate per port do override WITH_/WITHOUT_ and >> OPTIONS_UNSET/OPTIONS_SET. > > Only, *after* setting "OPTIONS_FILE_UNSET+=TK" in lang_ocaml/options, I was able to get unison-nox11 port compiled by poudriere successfully. *Before* I haven't had any lang_ocaml/options settings at all. And because the default setting of ocaml-nox11 is "OPTIONS_FILE_SET+=TK" -which requires X11 support (!)- poudriere fails compiling ocaml-nox11 port. (If I am not mistaken miserably.) > Yes, looking at the ocaml port Makefile, it requires those to be disabled separately, it will mark the port as IGNORE if conflicting options are requested. Please note that the options framework isn't smart enough to manage this kind of dependencies, when using options care is required by the user. Anyway if you have a better proposal you can file a PR with a patch against the ocaml port.(which I do not maintain, and know very little of) -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550E8DF5.1020708>