From owner-cvs-all@FreeBSD.ORG Fri Dec 14 00:12:54 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5703716A418 for ; Fri, 14 Dec 2007 00:12:54 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id E0E3F13C461 for ; Fri, 14 Dec 2007 00:12:53 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id lBE0CiAs023565; Thu, 13 Dec 2007 17:12:44 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <4761CA63.702@samsco.org> Date: Thu, 13 Dec 2007 17:12:19 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Kip Macy References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Thu, 13 Dec 2007 17:12:45 -0700 (MST) X-Spam-Status: No, score=-1.4 required=5.4 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: src-committers@FreeBSD.org, Kip Macy , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Julian Elischer , "Bjoern A. Zeeb" Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 00:12:54 -0000 No Scott Kip Macy wrote: > Should we repocopy? > > -Kip > > On Dec 13, 2007 3:08 PM, Julian Elischer wrote: >> Bjoern A. Zeeb wrote: >>> On Wed, 12 Dec 2007, Kip Macy wrote: >>> >>> Hi, >>> >>>> kmacy 2007-12-12 20:21:39 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/conf files >>>> sys/netinet tcp_var.h >>>> sys/sys socket.h >>>> Added files: >>>> sys/netinet tcp_ofld.c tcp_ofld.h toedev.h >>>> Log: >>>> Add driver independent interface to offload active established TCP >>>> connections >>>> >>>> Reviewed by: silby >>>> >>>> Revision Changes Path >>>> 1.1256 +1 -0 src/sys/conf/files >>>> 1.1 +126 -0 src/sys/netinet/tcp_ofld.c (new) >>>> 1.1 +198 -0 src/sys/netinet/tcp_ofld.h (new) >> I think I'd have just gone for >> tcp_offload.c >> it's not the longest filename in the system. >> >> >>> I consider that just for the archives .. >>> >>> .. but is there a reason you abbreviated those file names like that? >>> It's not like we live with 8.3 contrainsts. >>> >>> The first time I parsed it as "of ld", then realiazed it should be >>> "off ld" and then wondered why it wasn't just "offload" like it is >>> "syncache" or "timewait" or "hostcache"? >>> >>> And yes, I wondered the same about the functions names, ... >>> >>> Was that spelling inherited from another implementation/standard/whatever? >>> >>> >>> >>>> 1.159 +4 -1 src/sys/netinet/tcp_var.h >>>> 1.1 +132 -0 src/sys/netinet/toedev.h (new) >>>> 1.96 +2 -0 src/sys/sys/socket.h >>>> >>