From owner-freebsd-current@FreeBSD.ORG Mon May 8 01:59:03 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C11916A403 for ; Mon, 8 May 2006 01:59:03 +0000 (UTC) (envelope-from caelian@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7619043D48 for ; Mon, 8 May 2006 01:59:02 +0000 (GMT) (envelope-from caelian@gmail.com) Received: by nz-out-0102.google.com with SMTP id i11so1058096nzi for ; Sun, 07 May 2006 18:59:01 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:subject:from:to:cc:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=oY4Z7qcM2ayyX899EuVQVdzGOFwI2R9ZaK0SYRJGA73HmO1uElUBPFc9OuyT6B0n2H7GinmBSqfnYryKCW3IeS2K9FQ912uCYjlF2pPY6OchD/HjXAFdlHSr0vrHrAUWlj/3/29ktJGpFFRX1y0TjY9VBydqptg5vpZx0id/3J0= Received: by 10.36.251.3 with SMTP id y3mr2641929nzh; Sun, 07 May 2006 18:59:01 -0700 (PDT) Received: from synergy.odyssey.homeunix.org ( [68.190.230.198]) by mx.gmail.com with ESMTP id 12sm3405514nzn.2006.05.07.18.59.00; Sun, 07 May 2006 18:59:01 -0700 (PDT) From: Pascal Hofstee To: current@FreeBSD.org Content-Type: text/plain Date: Sun, 07 May 2006 18:58:58 -0700 Message-Id: <1147053538.17191.26.camel@synergy.odyssey.homeunix.org> Mime-Version: 1.0 X-Mailer: Evolution 2.7.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: amd64@FreeBSD.org Subject: [Fwd: Re: [head tinderbox] failure on amd64/amd64] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2006 01:59:03 -0000 The following is the end result of a small conversation i had with Sam Leffler regarding the recent ath_hal commit breaking buildkernel on amd64 ... i figured i should probably send the lists about this until a fix gets committed. -------- Forwarded Message -------- From: Pascal Hofstee To: Sam Leffler Subject: Re: [head tinderbox] failure on amd64/amd64 Date: Sun, 07 May 2006 18:32:36 -0700 On Sun, 2006-05-07 at 17:59 -0700, Sam Leffler wrote: > Don't know what to say; I routinely build custom kernels w/ and w/o > ath_hal in the config file and/or the MODULES_OVERRIDE list w/o problems. I had a closer look at the warnings .. and i have at least figured out what's causing the error. The build is complaining it doesn't know how to make the file /usr/src/sys/modules/ath_hal/../../contrib/dev/ath/ public/amd64-elf.opt_ah.h Upon closer inspection this file indeed doesn't exist .. but x86_64-elf.opt_ah.h does, it looks like somewhere the translation from amd64 to x86_64 doesn't take place properly. At this point i decided to take a closer look at the /usr/src/sys/modules/ath_hal/Makefile As it turns out .. the addition of the line to unbreak the Sparc64 build, results in breaking the translation for AMD64. ATH_MODULE_ARCH=${MACHINE_ARCH:S/amd64/x86_64/} ATH_MODULE_ARCH=${MACHINE_ARCH:S/sparc64/sparc64-be/} if i comment the sparc64 entry, make -V ATH_MODULE_ARCH properly returns x86_64 .. if i leave it uncommented make -V ATH_MODULE_ARCH returns amd64 again. I would assume the proper solution here to be to set the ATH_MODULE_ARCH variable conditionally based on MACHINE_ARCH instead of two consecutive definitions as is currently the case. Please correct me if i am wrong ?