From owner-freebsd-net@FreeBSD.ORG  Thu May 17 02:37:37 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 78AFA106566C;
	Thu, 17 May 2012 02:37:37 +0000 (UTC)
	(envelope-from devon.odell@gmail.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 402F88FC1C;
	Thu, 17 May 2012 02:37:37 +0000 (UTC)
Received: by dadv36 with SMTP id v36so1975629dad.13
	for <multiple recipients>; Wed, 16 May 2012 19:37:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type:content-transfer-encoding;
	bh=vd48iqhHDxOWXcc+PxcrNG4w8HSh1/N9lkTle1ffD3M=;
	b=DCGkRzcKQqT/H5h5URr6bOFLXrvHFInjmdgBUONwJ/+q7zNFM8tLFRs7ligJ3dvURQ
	SakDeurRmEgT0DrpMcyZEi/UkoqKYHrCRsPpNvFZ93NdT/j2aJ2pwWhRJsG20/ECp3gk
	i+m+WYTG8TcuUqwllR+vc4gSIErjMvrGLbE2w3ZdGhijSXW8aP5xK7E+HhzPKRHJrjKM
	7zx5qM93U6wggRs3sQyoZ2+oZ9eSlnPQ1OQQYDLj3Jk/Rlj9gRR9sTfdqlze+24WtLl8
	n9JBZjsUH1d293veHnXt/lZNi1VodITqUq3yr7GXudNPuv7BUoWb9ZMtHgcMrlfOF3P4
	Sx6g==
MIME-Version: 1.0
Received: by 10.68.223.234 with SMTP id qx10mr21464146pbc.154.1337222256803;
	Wed, 16 May 2012 19:37:36 -0700 (PDT)
Received: by 10.68.204.162 with HTTP; Wed, 16 May 2012 19:37:36 -0700 (PDT)
In-Reply-To: <CAFgOgC9k7wuw+Ji7wyLMjOBzGko5fPw1o2UGQdvetC8Q6ge1vw@mail.gmail.com>
References: <CAFgOgC9k7wuw+Ji7wyLMjOBzGko5fPw1o2UGQdvetC8Q6ge1vw@mail.gmail.com>
Date: Wed, 16 May 2012 22:37:36 -0400
Message-ID: <CAFgOgC_d7H7KbmJNfLosuKDHL-Ov1W-zxHLzfx_-Z9WmVW7F9A@mail.gmail.com>
From: "Devon H. O'Dell" <devon.odell@gmail.com>
To: bug-followup@freebsd.org, freebsd-net@freebsd.org, gavin@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: 
Subject: Re: kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR
	in ether_ioctl()
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2012 02:37:37 -0000

2012/5/16 Devon H. O'Dell <devon.odell@gmail.com>:
> Hi Gavin, freebsd-net,
>
> --- if_ethersubr.c =A0 =A0 =A02011-09-22 20:51:37.000000000 -0400
> +++ /home/dho/if_ethersubr.c =A0 =A02012-05-16 22:27:17.000000000 -0400
> @@ -1146,7 +1146,9 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0switch (ifa->ifa_addr->sa_family) {
> =A0#ifdef INET
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case AF_INET:
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_init(ifp->if_softc)=
; =A0 =A0/* before arpwhohas */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (ifp->if_flags & IFF_RUN=
NING =3D=3D 0) {

That's probably ((ifp->if_flags & IFF_RUNNING) =3D=3D 0). Also, I'm not on
freebsd-net or cc'ed on the PR afaik, so please cc me explicitly on
followups if more information is needed.

--dho

> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_ini=
t(ifp->if_softc); =A0 =A0/*
> before arpwhohas */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0arp_ifinit(ifp, ifa);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> =A0#endif