From owner-freebsd-smp Fri Feb 23 11: 1:14 2001 Delivered-To: freebsd-smp@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 70E4337B503; Fri, 23 Feb 2001 11:01:11 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f1NJ0sK28310; Fri, 23 Feb 2001 11:00:54 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.1) id f1NJ0Ej76425; Fri, 23 Feb 2001 11:00:14 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3A963FB5.995FEA7D@elischer.org> Date: Fri, 23 Feb 2001 11:00:14 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Julian Elischer Subject: Re: NETGRAPH broken with witness Cc: julian@FreeBSD.ORG, smp@FreeBSD.ORG, Kris Kennaway Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 23-Feb-01 Julian Elischer wrote: > Kris Kennaway wrote: >> >> On Fri, Feb 23, 2001 at 01:57:36AM -0800, Julian Elischer wrote: >> > Kris Kennaway wrote: >> > > >> > > Apparently this was never tested: early in the boot phase I get the >> > > following panic: >> > > >> > > panic: spin lock netgraph worklist mutex not in order list >> > > >> > > and indeed the witness code appears to have no knowledge of the >> > > netgraph spinlocks. >> > >> > so how is it supposed to know? >> >> From what I can gather, you add the locking hierarchy to be enforced >> to spin_order_list in kern.mutex.c > > hmm tricky.. I thought initiating the damned thing would insert it. For sleep mutexes it is automatic, yes. Spin mutexes are intended to only be used in very low level code and thus only in places where the order can be easily laid out. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message