Date: Fri, 6 Nov 2015 15:52:22 +0100 From: Zbigniew Bodek <zbb@semihalf.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org> Subject: Re: HEADS UP: Cavium ThunderX support in the tree Message-ID: <CAG7dG%2Bw7EUF2v=mBGTs0j-9V85cG5h3un=tWc_AejFskVLRyLg@mail.gmail.com> In-Reply-To: <20151106144511.3309d8b2@bender> References: <CAG7dG%2BxzC_SGiFtncTd7tbi_VqmyXj_08JY34hKFDkvnSg1PPw@mail.gmail.com> <20151106094714.5e8632c6@bender.Home> <CAG7dG%2ByvGq=-vRo3swCGD_goo6UhQy3CW66GUbikUVOvVYkA6Q@mail.gmail.com> <20151106113641.02e0f826@bender> <CAG7dG%2BwN-%2BT2SggMy1Of0h3X613owqbcTD%2BnUcKdV_C=ggOfMA@mail.gmail.com> <20151106144511.3309d8b2@bender>
next in thread | previous in thread | raw e-mail | index | archive | help
2015-11-06 15:45 GMT+01:00 Andrew Turner <andrew@fubar.geek.nz>: > On Fri, 6 Nov 2015 13:10:10 +0100 > Zbigniew Bodek <zbb@semihalf.com> wrote: > >> 2015-11-06 12:36 GMT+01:00 Andrew Turner <andrew@fubar.geek.nz>: >> > On Fri, 6 Nov 2015 12:23:11 +0100 >> > Zbigniew Bodek <zbb@semihalf.com> wrote: >> >> Secondly, EFI that runs on the board needs to pass the correct DTB >> >> to the kernel (it has to have PCIB, BGX, MDIO, PHYs nodes and they >> >> need to be in the correct order [MDIO needs to attach before >> >> BGX]). >> > If this is the case the code is broken. It should just work with >> > the vendor dtb and GENERIC. >> >> Thanks for quick evaluation but please see comment below. >> >> > >> > We already have to handle this in other parts of the code by having >> > the dependent drivers on an earlier pass than later drivers. >> >> MDIO is a platform device whereas BGX, NICPF (physical function) and >> NICVF (virtual function) are devices on PCI. >> Therefore if the PCIB is placed prior to MDIO in DTB all devices on >> this PCI bridge will be attached before MDIO is attached. >> As far as I know there is no straightforward way to create a logical >> relation between device on PCI and platform devices enumerated using >> DTB. >> That is why we asked Cavium to change the order in their DTBs. >> Of course if you know how to workaround that I would be happy to apply >> this change to "unbreak" the existing code. > > No need, I've fixed it in r290448. > > Andrew OK. Thanks! Best regards zbb
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG7dG%2Bw7EUF2v=mBGTs0j-9V85cG5h3un=tWc_AejFskVLRyLg>