From owner-svn-src-all@FreeBSD.ORG Fri Jul 16 19:14:12 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 75E911065677; Fri, 16 Jul 2010 19:14:12 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Bruce Evans Date: Fri, 16 Jul 2010 15:14:02 -0400 User-Agent: KMail/1.6.2 References: <201007131657.o6DGvq9L097594@svn.freebsd.org> <20100715220012.X1719@delplex.bde.org> In-Reply-To: <20100715220012.X1719@delplex.bde.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007161514.04955.jkim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r210005 - head/sys/modules/acpi/acpi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2010 19:14:12 -0000 On Thursday 15 July 2010 08:04 am, Bruce Evans wrote: > On Tue, 13 Jul 2010, Jung-uk Kim wrote: > > Log: > > Define SMP unconditionally for amd64 and remove opt_global.h > > from SRCS. Note it is done just for correctness sake because we > > do not build, ship, or support acpi.ko on amd64. > > > > Prodded by: bde > > Thanks. > > It was much more interesting than I noticed. Modules are supposed > to be independent of all configuration options, especially global > ones, especially especially SMP. Perhaps this is too much to ask > for acpi. Does it work now, after you removed an SMP ifdef from it? I removed "#ifdef SMP" from acpi.c because 'smp_started' is available for both UP and SMP kernels. On the other hand, I cannot remove these easily from sys/amd64/acpica/acpi_wakeup.c, i.e., it requires some symbols from sys/amd64/amd64/mp_machdep.c, which are only available in SMP case. FYI, we never had to worry about acpi.ko on i386 because we didn't implement suspend/resume for SMP case in the first place. X-) Jung-uk Kim