From owner-freebsd-hackers@freebsd.org Sat Apr 11 03:37:26 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 56D9E2AD167 for ; Sat, 11 Apr 2020 03:37:26 +0000 (UTC) (envelope-from neel@neelc.org) Received: from rainpuddle.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48zgYd1M9tz43jD; Sat, 11 Apr 2020 03:37:24 +0000 (UTC) (envelope-from neel@neelc.org) Received: from mail.neelc.org (rainpuddle.neelc.org [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622]) by rainpuddle.neelc.org (Postfix) with ESMTPSA id 0AAB3B2835; Fri, 10 Apr 2020 20:37:17 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 10 Apr 2020 20:37:16 -0700 From: Neel Chauhan To: lev@freebsd.org Cc: "Andrey V. Elsukov" , "Rodney W. Grimes" , freebsd-hackers@freebsd.org Subject: Re: Committing one ipfw(8) userland patch In-Reply-To: <1bc864df-0b09-fad4-3781-d7975c385b0e@FreeBSD.org> References: <202004071735.037HZ1mK093414@gndrsh.dnsmgr.net> <7284239b-e335-b219-b28a-386f0edd4f8e@yandex.ru> <1bc864df-0b09-fad4-3781-d7975c385b0e@FreeBSD.org> User-Agent: Roundcube Webmail/1.4.1 Message-ID: X-Sender: neel@neelc.org X-Rspamd-Queue-Id: 48zgYd1M9tz43jD X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=neelc.org; spf=pass (mx1.freebsd.org: domain of neel@neelc.org designates 2001:19f0:8001:fed:5400:2ff:fe73:c622 as permitted sender) smtp.mailfrom=neel@neelc.org X-Spamd-Result: default: False [-5.99 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-3.29)[ip: (-9.83), ipnet: 2001:19f0:8000::/38(-4.91), asn: 20473(-1.64), country: US(-0.05)]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[neelc.org,none]; RCVD_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:2001:19f0:8000::/38, country:US]; FREEMAIL_CC(0.00)[yandex.ru]; MID_RHS_MATCH_FROM(0.00)[]; ONCE_RECEIVED(0.10)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 03:37:26 -0000 Thank you all for your feedback. Using the same Phabricator revision here: https://reviews.freebsd.org/D24234 I have added the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers and made src-ip/dst-ip dual-stack, to be consistent with me/me4/me6 described in this thread. Could you all please give your opinions on it? -Neel On 2020-04-10 04:10, Lev Serebryakov wrote: > On 10.04.2020 13:46, Andrey V. Elsukov wrote: > >> On 07.04.2020 20:35, Rodney W. Grimes wrote: >>> But that is not what this review does. I would be in support of >>> changing the "official" names to src-ip4/dst-ip4/src-ip6/dst-ip6 >>> and making src-ip/dst-ip a backwards compatible alias. >> >> I also think this idea sounds better. > > +1