From owner-freebsd-current@FreeBSD.ORG Thu Nov 27 06:33:34 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7410316A4CE for ; Thu, 27 Nov 2003 06:33:34 -0800 (PST) Received: from python.evilrealms.net (evilrealms.demon.co.uk [62.49.12.231]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CEA143FEA for ; Thu, 27 Nov 2003 06:33:33 -0800 (PST) (envelope-from jay@evilrealms.net) Received: from evilrealms.net (viper.evilrealms.net [192.168.1.2]) by python.evilrealms.net (Postfix) with ESMTP id CB1185C3C; Thu, 27 Nov 2003 14:33:28 +0000 (GMT) Message-ID: <3FC60B3B.2000403@evilrealms.net> Date: Thu, 27 Nov 2003 14:33:31 +0000 From: Jay Cornwall User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031013 Thunderbird/0.3 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Daan Vreeken [PA4DAN]" References: <1069874342.704.18.camel@klotz.local> <1069888991.2521.7.camel@klotz.local> <3FC54095.6030209@evilrealms.net> <200311270856.44214.Danovitsch@Vitsch.net> In-Reply-To: <200311270856.44214.Danovitsch@Vitsch.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-current@freebsd.org Subject: Re: Panic with ugen X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2003 14:33:34 -0000 Daan Vreeken [PA4DAN] wrote: > If you have time left, could you perhaps also have a look at kern/51186? > I have filed it back in March and it's still open. (Fixes a memory corruption > bug in ugen). I'm not a committer, I'm afraid, so it's probably best to get in touch with the code maintainer. (imp@freebsd.org, if the PR is correct - he did reply at the bottom of the PR) But from a brief look at the code, I can't see anything getting past this line: if(sce->fill < sce->cur && sce->cur <= sce->fill + count) If sce->fill is less than sce->cur, then sce->cur can only be <= (sce->fill + count) if count is negative. But I haven't studied the code that closely, so maybe I'm just missing something obvious. :) -- Cheers, Jay http://www.evilrealms.net/ - Systems Administrator & Developer http://www.imperial.ac.uk/ - 3rd year CS student