From owner-freebsd-acpi@FreeBSD.ORG Fri Nov 5 03:57:55 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FE6D106564A; Fri, 5 Nov 2010 03:57:55 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx1.freebsd.org (Postfix) with ESMTP id 3220D8FC15; Fri, 5 Nov 2010 03:57:54 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 04 Nov 2010 20:57:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.58,300,1286175600"; d="scan'208";a="674540892" Received: from orsmsx603.amr.corp.intel.com ([10.22.226.49]) by orsmga001.jf.intel.com with ESMTP; 04 Nov 2010 20:57:54 -0700 Received: from orsmsx503.amr.corp.intel.com ([10.22.226.47]) by orsmsx603.amr.corp.intel.com ([10.22.226.49]) with mapi; Thu, 4 Nov 2010 20:57:54 -0700 From: "Moore, Robert" To: "Moore, Robert" , Hans Petter Selasky , Jung-uk Kim , "freebsd-acpi@freebsd.org" Date: Thu, 4 Nov 2010 20:57:53 -0700 Thread-Topic: MacBookPro 5,1 Thread-Index: Act78/xATnxsujcQTGeF1xiG0DQ7CgAm1KMQAANcfwA= Message-ID: <4911F71203A09E4D9981D27F9D830858BC46A4B1@orsmsx503.amr.corp.intel.com> References: <201010121209.06397.hselasky@c2i.net> <4CD02E6D.1070106@freebsd.org> <201011021529.05977.jkim@FreeBSD.org> <201011040844.17109.hselasky@c2i.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Therien, Guy" Subject: RE: MacBookPro 5,1 X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 03:57:55 -0000 The problem is stale pointers within the structure, yes? Cannot copy the structure. I will never do this kind of thing again. When ACPICA was designed 12 years ago, memory was expensive. Bob >-----Original Message----- >From: Moore, Robert >Sent: Thursday, November 04, 2010 7:24 PM >To: 'Hans Petter Selasky'; Jung-uk Kim; freebsd-acpi@freebsd.org >Subject: RE: MacBookPro 5,1 > > >You cannot assume that a full memcpy has been performed on the structure >when you invoke the equals operator. > >This is basic C > > > > > >>-----Original Message----- >>From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >>acpi@freebsd.org] On Behalf Of Hans Petter Selasky >>Sent: Thursday, November 04, 2010 12:44 AM >>To: Jung-uk Kim; freebsd-acpi@freebsd.org >>Subject: Re: MacBookPro 5,1 >> >>On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote: >>> > Hans, >>> > >>> > could you please test the following patch? >>> > >>> > diff --git a/sys/dev/acpica/acpi_pci_link.c >>> > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644 >>> > --- a/sys/dev/acpica/acpi_pci_link.c >>> > +++ b/sys/dev/acpica/acpi_pci_link.c >>> > @@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs >>> > >>> > link->l_irq; >>> > else >>> > resptr->Data.ExtendedIrq.Interrupts[0] = =3D >>0; >>> > >>> > + memset(&resptr->Data.ExtendedIrq.ResourceSource= , >>0, >>> > + sizeof(ACPI_RESOURCE_SOURCE)); >>> > >>> > link++; >>> > i++; >>> > break; >> >>The "Bug" statements disappeared with this patch! Which patch is next to >>try? >> >>--HPS >>_______________________________________________ >>freebsd-acpi@freebsd.org mailing list >>http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >>To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"