From owner-cvs-all  Thu Apr  4 15:21:56 2002
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id 762B037B405; Thu,  4 Apr 2002 15:21:52 -0800 (PST)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g34NLiYm081945;
	Thu, 4 Apr 2002 15:21:44 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g34NKTrX081935;
	Thu, 4 Apr 2002 15:20:29 -0800 (PST)
Date: Thu, 4 Apr 2002 15:20:29 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Mikhail Teterin <mi@aldan.algebra.com>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/yacc main.c
Message-ID: <20020404152029.A81900@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200204042215.g34MFDb67996@freefall.freebsd.org> <200204042243.g34MhonF007316@aldan.algebra.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200204042243.g34MhonF007316@aldan.algebra.com>; from mi@aldan.algebra.com on Thu, Apr 04, 2002 at 05:43:50PM -0500
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Apr 04, 2002 at 05:43:50PM -0500, Mikhail Teterin wrote:
> >   Use strlen() rather than magic number.
> [...]
> 
> Beware of strlen :) The magic number was just a ``sizeof temp_form'' --
> computed at the code-writing time. Your change moved the computation to
> run-time, which, IMHO, is too far.

There is nothing wrong with run-time checks.  You are also missing the
point which is to reduce differences with *BSD, not add more.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message