From owner-freebsd-ports-bugs@freebsd.org Sat Apr 14 08:57:12 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAD82F8CC7A for ; Sat, 14 Apr 2018 08:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 312B17F8D6 for ; Sat, 14 Apr 2018 08:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E552FF8CC71; Sat, 14 Apr 2018 08:57:11 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A98B3F8CC6C for ; Sat, 14 Apr 2018 08:57:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42E377F8AF for ; Sat, 14 Apr 2018 08:57:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 73B2120020 for ; Sat, 14 Apr 2018 08:57:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w3E8vAw3056930 for ; Sat, 14 Apr 2018 08:57:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w3E8vAHI056929 for ports-bugs@FreeBSD.org; Sat, 14 Apr 2018 08:57:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227500] audio/mous: update to 2.0.1 Date: Sat, 14 Apr 2018 08:57:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2018 08:57:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227500 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #2 from Tobias Kortkamp --- Thanks for your submission. While this looks mostly ok to me there here are couple of things that could be improved. Can you submit an updated patch? +MASTER_SITES=3D GH USE_GITHUB=3Dyes already implies the same, so this can be removed. +PORTVERSION=3D 2.0.1 +DISTVERSIONPREFIX=3D v ... +GH_TAGNAME=3D v2.0.1 Remove GH_TAGNAME. DISTVERSIONPREFIX + PORTVERSION already sets it to the same value. +CMAKE_ARGS+=3D -DWITH_PLUGIN_ALSA=3D0 \ + -DWITH_PLUGIN_LIBAO=3D0 \ + -DWITH_PLUGIN_COREAUDIO=3D0 \ + -DWITH_PLUGIN_FAAC=3D0 \ + -DWITH_PLUGIN_FAAD=3D0 \ + -DWITH_PLUGIN_WMA=3D0 This should use CMAKE_OFF i.e. CMAKE_OFF=3D WITH_PLUGIN_ALSA \ WITH_PLUGIN_LIBAO \ WITH_PLUGIN_COREAUDIO \ WITH_PLUGIN_FAAC \ wITH_PLUGIN_FAAD \ WITH_PLUGIN_WMA +SNDIO_CMAKE_ON=3D -DWITH_PLUGIN_SNDIO=3D1 +SNDIO_CMAKE_OFF=3D -DWITH_PLUGIN_SNDIO=3D0 This can be replaced by the much easier to read SNDIO_CMAKE_BOOL=3D WITH_PLUGIN_SNDIO This also applies to all the other *_CMAKE_{ON,OFF} pairs. +USES=3D cmake:outsource,noninja compiler:c++14-lang Why is noninja needed? Having a small comment in the Makefile to explain why it's needed is always nice. +INSTALL_TARGET=3D install/strip This can probably be removed too. Uses/cmake.mk already sets it. --=20 You are receiving this mail because: You are the assignee for the bug.=