From owner-freebsd-net@FreeBSD.ORG  Tue Jan  3 22:20:00 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7FC0E106567C;
	Tue,  3 Jan 2012 22:20:00 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
	by mx1.freebsd.org (Postfix) with ESMTP id 35FEE8FC1C;
	Tue,  3 Jan 2012 22:20:00 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.sbone.de (Postfix) with ESMTPS id 1468B25D37C7;
	Tue,  3 Jan 2012 22:19:59 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
	[IPv6:fde9:577b:c1a9:31::2013:2742])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPS id 4F5B0BD869D;
	Tue,  3 Jan 2012 22:19:58 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
	by content-filter.sbone.de (content-filter.sbone.de
	[fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
	with ESMTP id a8TrLAa1VHJ3; Tue,  3 Jan 2012 22:19:57 +0000 (UTC)
Received: from orange-en1.sbone.de (orange-en1.sbone.de
	[IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPSA id 1E9F5BD869C;
	Tue,  3 Jan 2012 22:19:57 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
In-Reply-To: <201112291527.26763.jhb@freebsd.org>
Date: Tue, 3 Jan 2012 22:19:56 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <76A806B1-6D12-46DD-BC9D-F3CBDC587330@FreeBSD.org>
References: <201112221130.01823.jhb@freebsd.org>
	<201112291527.26763.jhb@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
X-Mailer: Apple Mail (2.1084)
Cc: freebsd-net@freebsd.org, Robert Watson <rwatson@freebsd.org>
Subject: Re: Transitioning if_addr_lock to an rwlock
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2012 22:20:00 -0000

On 29. Dec 2011, at 20:27 , John Baldwin wrote:
> I've gone ahead with this approach.  I have three separate patches =
that should
> implement Phase 1.  All of them can be found at
> http://www.FreeBSD.org/~jhb/patches/
>=20
> - if_addr_dev.patch      This fixes a few new device drivers that were =
using
>                         the locking macros directly rather than the =
wrapper
>                         functions Robert added.  I've already sent =
this
>                         directly to the relevant driver maintainers =
for their
>                         review.
> - if_addr_macros.patch   This adds new locking macros to support read =
locks vs
>                         write locks.  However, they all still map to =
mutex
>                         operations.

The first two look good.  I wondered why you didn't need the =
r-wraper-functions
but obviously they had been named like that already:)


I'll look at the one below in more detail and get back to you.

> - if_addr_uses.patch     This changes callers of the existing macros =
to use
>                         either read or write locks.  This is the patch =
that
>                         could use the most review.

--=20
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!