From owner-svn-src-all@freebsd.org Sat Sep 26 05:11:35 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F32E2A08EC3; Sat, 26 Sep 2015 05:11:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x22e.google.com (mail-qg0-x22e.google.com [IPv6:2607:f8b0:400d:c04::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B146F1797; Sat, 26 Sep 2015 05:11:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qgev79 with SMTP id v79so85136018qge.0; Fri, 25 Sep 2015 22:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VmNjX32459xVA1iT6w4DJ//9s1LQzQLWG0BKkeJUgN8=; b=tUr/7rAWxFEoL6s/E5XvUi1iriDJi8MsiWiPfbSz7pE2qfxWoPBRu7TQiBC/OsDi3q J+M2ho+5w1DPWA8e6ScseYbUwUu3nEx6TcEo1ye36qej2hYrBajvUidh3OAS99mzY6Mc RswolBp9/0CnYNrU7dsZVqZPKDxn5x5u9BPpN3otAdN88m8m5kSo7sEDJWBP3HMw3Sc8 TRhpJKQD0v1kRnrX8yKjPQDlYApSgAvOaFhzByxrd3CR10zCYZjgZjIbxRWFh4O+dy3F M9FeBvtAV8bsD72j2uYbYO6RxMlknF198Z80Uq7FL8yZiD1WkFoSxLYK3TrzwCX+f9eE +zvw== MIME-Version: 1.0 X-Received: by 10.140.101.226 with SMTP id u89mr10448928qge.90.1443244294847; Fri, 25 Sep 2015 22:11:34 -0700 (PDT) Received: by 10.140.94.44 with HTTP; Fri, 25 Sep 2015 22:11:34 -0700 (PDT) In-Reply-To: <5605D4FC.4040205@FreeBSD.org> References: <201509252303.t8PN3Wx0098623@repo.freebsd.org> <5605D4FC.4040205@FreeBSD.org> Date: Fri, 25 Sep 2015 22:11:34 -0700 Message-ID: Subject: Re: svn commit: r288241 - head/share/mk From: NGie Cooper To: Bryan Drewery Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 05:11:36 -0000 On Fri, Sep 25, 2015 at 4:13 PM, Bryan Drewery wrote: > On 9/25/2015 4:12 PM, NGie Cooper wrote: >> On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery wrote: >>> Author: bdrewery >>> Date: Fri Sep 25 23:03:32 2015 >>> New Revision: 288241 >>> URL: https://svnweb.freebsd.org/changeset/base/288241 >>> >>> Log: >>> Remove 'set -e' that are no longer needed as it is already default. >>> >>> When bmake was initially imported at r241298 shell commands were no longer >>> ran with 'set -e' as they were before. This was fixed in r254980 so they >>> again always use 'set -e'. >> >> The bsd.subdir.mk portion of the change looks like it would cause >> issues depending on what's being called (fmake or an earlier version >> of sys.mk might be used at install time). >> > > We only support bmake in head. And the 'set -e' were only added for > bmake compatibility before it was fixed to work like fmake did. Sorry. Fuzzy memory on the latter item. Yeah, I requested it a couple years ago. We might only support bmake in head, but there's nothing preventing someone from doing a source upgrade from one of the older 10 releases to 11+. Thinking about this a bit more, this is an extreme edge case that doesn't really matter, because people doing source upgrades across major releases really should be doing them from the latest minor release for the major release.