Date: Tue, 16 Mar 2021 20:59:29 +0100 From: Adriaan de Groot <adridg@freebsd.org> To: Mathieu Arnold <mat@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Message-ID: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> In-Reply-To: <20210316021909.GB21936@FreeBSD.org> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart22486965.gYbqZ1YImA
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Adriaan de Groot <adridg@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files
Date: Tue, 16 Mar 2021 20:59:29 +0100
Message-ID: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org>
Organization: FreeBSD
In-Reply-To: <20210316021909.GB21936@FreeBSD.org>
References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org>
On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote:
> On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote:
> > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > > > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > > > + # Drop all leading spaces in the script, to minify
> > > > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL}
> > >
> > > [[:space:]] works with all versions.
> >
> > Yes please. Not just it's more robust, it also expresses the intention
> > better, as we probably want to trim *any* unnecessary whitespace, not
> > some particular character.
>
> So, anything prevents us from going the [[:blank:]] way?
So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to prod
at this right now.
[ade] (a character class accepting a, d or e, obvs)
--nextPart22486965.gYbqZ1YImA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAmBRDiEACgkQz93JbxKx
kVyBpQv/dAFbVw4M0rsXkj+tPxCxwBedIcDfdlZiqQ/9A1tEzd9d+AZuPhrCHl7A
zPZaUrYSTjKwzFcw8bepEs9IB1oUgudw4zn28dqJH04MZQzvVaEtU4yMkHxymxnc
w3xCbKHpwhEjm1WVrt/JsMhF46k74YrVkl2U7Mg+XRYpc3cuIXzpnltc1mHDd3h6
8+jDBltCI8siGBbsnHAVyCDhecl4/ZW/RtYSrnyirBVtjxpR4AH/igJzQva/ffVf
QWAcPMnR6QDZlSezDO9BowuqUR/0vMU3KWh9NUoMDmKGufsyAmMNcBUa2L56Cr0k
SOcDjR7Dm6Deql5jDy1WhQwSU7PAz4aoKOe9BqJjLPqw6reysrZJxPzjrVJj0+xe
LTkUiuE46pwB7YHPc1f6j8l2tWxoQLDacXpi/qqwG47rAhM+04n3mb+61jY+ZPGj
d3UksoFoxFIrPJ10u/VR7PqXu1511BwY5Vb+Abof10m4hrtHmSm7IT0q3t/pAUBJ
+SLtzokX
=tEqC
-----END PGP SIGNATURE-----
--nextPart22486965.gYbqZ1YImA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1829118.vR5SVPPSqJ>