From owner-svn-src-user@FreeBSD.ORG Mon Oct 22 20:04:13 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D9D13BF; Mon, 22 Oct 2012 20:04:13 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id A94898FC17; Mon, 22 Oct 2012 20:04:13 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9MK4Dh0093472; Mon, 22 Oct 2012 20:04:13 GMT (envelope-from crees@svn.freebsd.org) Received: (from crees@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9MK4DZl093470; Mon, 22 Oct 2012 20:04:13 GMT (envelope-from crees@svn.freebsd.org) Message-Id: <201210222004.q9MK4DZl093470@svn.freebsd.org> From: Chris Rees Date: Mon, 22 Oct 2012 20:04:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r241911 - user/crees/rclint X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 20:04:13 -0000 Author: crees (ports committer) Date: Mon Oct 22 20:04:13 2012 New Revision: 241911 URL: http://svn.freebsd.org/changeset/base/241911 Log: Correct errors Modified: user/crees/rclint/errors.en Modified: user/crees/rclint/errors.en ============================================================================== --- user/crees/rclint/errors.en Mon Oct 22 20:02:36 2012 (r241910) +++ user/crees/rclint/errors.en Mon Oct 22 20:04:13 2012 (r241911) @@ -13,7 +13,9 @@ functions_short One-line functions disco orphaned_line Orphaned line Do not put unassociated shell commands inside rc scripts; put them inside functions +rcorder_keyword_freebsd Do not include FreeBSD in the KEYWORD rcorder line Historically FreeBSD scripts were marked in the KEYWORD section. This is no longer necessary rcorder_order rcorder block in the wrong order; should be PROVIDE/REQUIRE/BEFORE/KEYWORD See the article on RC scripting +rcvar_incorrect rcvar is not set correctly rcvar must be directly set to name_enable. Do not quote, and do not use indirection; ${name}_enable is slower than example_enable shebang Incorrect shebang used All rc scripts must start with the correct shebang; #!/bin/sh @@ -27,23 +29,6 @@ value_quoted Do not quote values unless -defaults_invalid Invalid lines in defaults block. Allowed are variable assignments (including eval statements) and comments. A blank line ends the block. - -definitions_missing Definitions block missing Following the default definitions must be other definitions (such as command, command_args) - -load_rc_config_extra load_rc_config not followed by blank line The load_rc_config line must form its own block -load_rc_config_missing load_rc_config is late, incorrect or missing Directly following the name/rcvar block must be load_rc_config $name, unquoted - -name_missing name is set late or not at all Directly following the sourcing of scripts must follow setting of the variable name -name_quoted name is quoted Do not quote the value of name. If it has spaces, use underscores - -rc_subr_late rc.subr sourcing late or nonexistent The first non-comment non-blank line in any rc file must be sourcing /etc/rc.subr - -rcorder_keyword_freebsd Do not include FreeBSD in the KEYWORD rcorder line Historically FreeBSD scripts were marked in the KEYWORD section. This is no longer necessary -rcorder_missing Missing rcorder block Following the FreeBSD RCSId keyword must be nothing but empty comment lines and an rcorder block - -rcvar_extra extra lines in name/rcvar block Order should be [blank line]/name=/rcvar=/[blank line] -rcvar_incorrect rcvar is not set correctly rcvar must be directly set to name_enable. Do not quote, and do not use indirection; ${name}_enable is slower than example_enable rcvar_missing rcvar is set late or not at all Setting rcvar must be done straight after setting name rcvar_quoted rcvar is quoted Do not quote the value of rcvar