From owner-freebsd-net@FreeBSD.ORG Wed Apr 25 19:44:10 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89C97106566B; Wed, 25 Apr 2012 19:44:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5D78E8FC1B; Wed, 25 Apr 2012 19:44:10 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C9A86B915; Wed, 25 Apr 2012 15:44:09 -0400 (EDT) From: John Baldwin To: Sean Bruno Date: Wed, 25 Apr 2012 15:43:08 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <1335312667.11564.13.camel@powernoodle-l7.corp.yahoo.com> <201204250932.21378.jhb@freebsd.org> <1335382225.2722.6.camel@powernoodle-l7.corp.yahoo.com> In-Reply-To: <1335382225.2722.6.camel@powernoodle-l7.corp.yahoo.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201204251543.09099.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 25 Apr 2012 15:44:09 -0400 (EDT) Cc: "freebsd-net@freebsd.org" , Jack Vogel Subject: Re: igb(4) Pondering a bind to cpu patch X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2012 19:44:10 -0000 On Wednesday, April 25, 2012 3:30:25 pm Sean Bruno wrote: > On Wed, 2012-04-25 at 06:32 -0700, John Baldwin wrote: > > CPU IDs are not guaranteed to be dense. However, you can use > > CPU_FIRST() and > > CPU_NEXT() with your static global instead. > > > Ah, does CPU_NEXT() reset to 0 when it reaches the end of its list of > CPUs? Yes. > > OTOH, if igb were to just leave the interrupts alone instead of > > binding them > > by hand, they would get round-robin assigned among available cores > > already. I > > think in this case the best approach might be to add a tunable to > > disable > > igb's manual binding and instead let the default system round-robin > > be > > preserved. > > also, yes. Why *are* we binding to CPUs in the first place? Are we > afraid that the scheduler won't do the right thing and we're trying to > work around some unknown performance issue ? Well, in some cases you want to know exactly which CPUs are being used as you might bind other resources associated with the queue to those specific CPUs as well. -- John Baldwin