From owner-freebsd-net@freebsd.org Thu Apr 20 20:20:14 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7DE6D47E7B for ; Thu, 20 Apr 2017 20:20:14 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from smtpq6.tb.mail.iss.as9143.net (smtpq6.tb.mail.iss.as9143.net [212.54.42.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 841A0172 for ; Thu, 20 Apr 2017 20:20:14 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from [212.54.42.134] (helo=smtp10.tb.mail.iss.as9143.net) by smtpq6.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1d1IYf-0003RR-To; Thu, 20 Apr 2017 22:20:05 +0200 Received: from 5ed15678.cm-7-2b.dynamic.ziggo.nl ([94.209.86.120] helo=wan0.bsd4all.org) by smtp10.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1d1IYf-000335-Qq; Thu, 20 Apr 2017 22:20:05 +0200 Received: from newnas (localhost [127.0.0.1]) by wan0.bsd4all.org (Postfix) with ESMTP id 7C19771E5; Thu, 20 Apr 2017 22:20:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at bsd4all.org Received: from wan0.bsd4all.org ([127.0.0.1]) by newnas (newnas.bsd4all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 28sjx7UWf5ke; Thu, 20 Apr 2017 22:20:03 +0200 (CEST) Received: from [192.168.1.64] (mm [192.168.1.64]) by wan0.bsd4all.org (Postfix) with ESMTPSA id 4DAA571D9; Thu, 20 Apr 2017 22:20:03 +0200 (CEST) From: peter.blok@bsd4all.org Message-Id: Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: MFC VIMAGE fixes to 11-stable Date: Thu, 20 Apr 2017 22:20:02 +0200 In-Reply-To: <20170420214128.29379fdb@x23> Cc: Kristof Provost , freebsd-net@freebsd.org To: Marko Zec References: <8E6FC1CD-24D5-46D5-A6A1-760DD612F92D@bsd4all.org> <20170420124256.1190665d@x23> <60C3FBF7-7CF3-49AF-9DDF-0589AE9D9146@sigsegv.be> <20170420152853.019e5480@x23> <20170420214128.29379fdb@x23> X-Mailer: Apple Mail (2.3273) X-SourceIP: 94.209.86.120 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.2 cv=Yup/f8QX c=1 sm=1 tr=0 a=IkzOOneQUJP1+bAPekPvBg==:17 a=AzvcPWV-tVgA:10 a=6Q3WNqvRAAAA:8 a=6I5d2MoRAAAA:8 a=vZYt9x9TnpZxVKE5IEUA:9 a=QEXdDO2ut3YA:10 a=utYTXG-_v9sLlgilx38A:9 a=vfJ5pP9RgKDJftyY:21 a=_W_S_7VecoQA:10 a=I8PBwKCn76L9oNdl0isp:22 a=IjZwj45LgO3ly-622nXo:22 none X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 20:20:14 -0000 Yeah, you are right. To keep the pf code as unchanged as possible, it is = sometimes unclear whether something is virtualised or not. The SLIST_HEAD and RB_HEAD in pfvar.h need virtualisation as well. > On 20 Apr 2017, at 21:41, Marko Zec wrote: >=20 > On Thu, 20 Apr 2017 21:24:33 +0200 > > wrote: >=20 >> It doesn=E2=80=99t solve my problem, but below is the stack back = trace that >> leads to the problem that allocation doen for the default vnet are >> given back as part of the vnet destroy. >>=20 >> #0 0xffffffff807ff275 at pfr_destroy_kentry+0x35 >> #1 0xffffffff807fe47c at pfr_remove_kentries+0x1fc >> #2 0xffffffff808053cd at pfr_setflags_ktable+0xcd >> #3 0xffffffff80802108 at pfr_clr_tables+0x248 >> #4 0xffffffff807ecd75 at vnet_pf_uninit+0x4a5 >> #5 0xffffffff806a9d2c at vnet_destroy+0x13c >> #6 0xffffffff8056cdcf at prison_deref+0x2af >> #7 0xffffffff805ee287 at taskqueue_run_locked+0x127 >> #8 0xffffffff805ef428 at taskqueue_thread_loop+0xc8 >> #9 0xffffffff80565505 at fork_exit+0x85 >> #10 0xffffffff808d245e at fork_trampoline+0xe >=20 > Having absolutely no clue what the PF code does or is supposed to do, > I'd bet that V_irtualizing pfr_ktablehead, and probably pfr_nulltable > and pfr_ktable_cnt as well, would help here. >=20 > Marko >=20 >>=20 >>=20 >>> On 20 Apr 2017, at 15:32, Kristof Provost >>> wrote: >>>=20 >>> On 20 Apr 2017, at 15:28, Marko Zec wrote: =20 >>>> Right. But pfi_attach_group_event() and the other handlers cited >>>> above _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding >>>> the proper vnet choice from the caller. >>>>=20 >>> Yes, that does look wrong. >>> I should have looked a bit further. >>>=20 >>>> Therefore the proper fix should be as simple as removing >>>> CURVNET_SET() / CURVNET_RESTORE() macro pairs from the cited >>>> handlers.=20 >>> Hopefully, yes. I=E2=80=99ve still got some other pf/vnet issues on = my todo >>> list, but I=E2=80=99ve now added this too. It might actually = explain some >>> other bug report I=E2=80=99ve seen (but not looked at in any depth). >>>=20 >>> Regards, >>> Kristof >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to >>> "freebsd-net-unsubscribe@freebsd.org" =20