From owner-freebsd-current@FreeBSD.ORG Sun Oct 17 16:50:48 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E30EA16A4CE for ; Sun, 17 Oct 2004 16:50:48 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3063543D2F for ; Sun, 17 Oct 2004 16:50:48 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i9HGoixj004719; Sun, 17 Oct 2004 18:50:46 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <4172A2D0.2060202@DeepCore.dk> Date: Sun, 17 Oct 2004 18:50:24 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jochen Gensch References: <4171AA66.2050005@gmx.de> In-Reply-To: <4171AA66.2050005@gmx.de> Content-Type: multipart/mixed; boundary="------------090403000301030809020004" X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: freebsd-current@freebsd.org Subject: Re: No booting - ata1-slave: FAILURE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 16:50:49 -0000 This is a multi-part message in MIME format. --------------090403000301030809020004 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Jochen Gensch wrote: > Hi, >=20 > I just cvsup'd RELENG_5 and the system is not booting any more with the= =20 > new kernel. It hangs at the ata identifying with the message: >=20 > ata1-slave: FAILURE - ATAPI_IDENTIFY timed out >=20 > I am using the GENERIC kernel, the only additional thing in there is=20 > atapicam. Maybe I just cvsup'd at a bad time :-) ? Maybe not, could you please try the attached patch and let me know if=20 that helps or not ? --=20 -S=F8ren --------------090403000301030809020004 Content-Type: text/plain; name="rel5.p1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rel5.p1" Index: ata-all.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v retrieving revision 1.222.2.4 diff -u -r1.222.2.4 ata-all.c --- ata-all.c 16 Oct 2004 08:43:06 -0000 1.222.2.4 +++ ata-all.c 17 Oct 2004 16:38:21 -0000 @@ -306,6 +306,12 @@ } } + ch->flags &= ~ATA_IMMEDIATE_MODE; + mtx_lock(&ch->state_mtx); + ch->state = ATA_IDLE; + mtx_unlock(&ch->state_mtx); + ch->locking(ch, ATA_LF_UNLOCK); + /* attach new devices */ if ((newdev = ~devices & ch->devices)) { if ((newdev & (ATA_ATA_MASTER | ATA_ATAPI_MASTER)) && @@ -323,12 +329,6 @@ if (bootverbose) ata_printf(ch, -1, "device config done ..\n"); - ch->flags &= ~ATA_IMMEDIATE_MODE; - mtx_lock(&ch->state_mtx); - ch->state = ATA_IDLE; - mtx_unlock(&ch->state_mtx); - ch->locking(ch, ATA_LF_UNLOCK); - ata_start(ch); return 0; } --------------090403000301030809020004--