From owner-p4-projects@FreeBSD.ORG  Mon Aug 10 09:55:48 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B9B511065673; Mon, 10 Aug 2009 09:55:47 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 79A6A106564A
	for <perforce@freebsd.org>; Mon, 10 Aug 2009 09:55:47 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 68F408FC15
	for <perforce@freebsd.org>; Mon, 10 Aug 2009 09:55:47 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7A9tlEE003896
	for <perforce@freebsd.org>; Mon, 10 Aug 2009 09:55:47 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7A9tlwx003894
	for perforce@freebsd.org; Mon, 10 Aug 2009 09:55:47 GMT
	(envelope-from trasz@freebsd.org)
Date: Mon, 10 Aug 2009 09:55:47 GMT
Message-Id: <200908100955.n7A9tlwx003894@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 167163 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2009 09:55:48 -0000

http://perforce.freebsd.org/chv.cgi?CH=167163

Change 167163 by trasz@trasz_anger on 2009/08/10 09:55:02

	Callback may cause loginclass refcount to drop to zero and be
	freed; use LIST_FOREACH_SAFE instead of LIST_FOREACH.

Affected files ...

.. //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#6 edit

Differences ...

==== //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#6 (text+ko) ====

@@ -208,9 +208,9 @@
     const struct hrl_rule *filter, void *arg3)
 {
 	int error;
-	struct loginclass *lc;
+	struct loginclass *lc, *lctmp;
 
-	LIST_FOREACH(lc, &loginclasses, lc_next) {
+	LIST_FOREACH_SAFE(lc, &loginclasses, lc_next, lctmp) {
 		error = (callback)(&lc->lc_limits, filter, arg3);
 		if (error)
 			return (error);