From owner-freebsd-ports@FreeBSD.ORG  Tue Dec 20 12:37:43 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F6F31065675;
	Tue, 20 Dec 2011 12:37:43 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
	by mx1.freebsd.org (Postfix) with ESMTP id 6BCA48FC12;
	Tue, 20 Dec 2011 12:37:43 +0000 (UTC)
Received: from [192.168.212.79] (unknown [210.79.217.13])
	by ainaz.pair.com (Postfix) with ESMTPSA id 477903F418;
	Tue, 20 Dec 2011 07:37:31 -0500 (EST)
Date: Tue, 20 Dec 2011 21:37:55 +0900 (EIT)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
In-Reply-To: <20111219192504.GA32480@troutmask.apl.washington.edu>
Message-ID: <alpine.LNX.2.00.1112202136320.27755@zbenl.fvgr>
References: <CAGFTUwPYkDrR4Damj8QEfaa6D6mRnt+1NrLCnzisYC2ZpHRVVg@mail.gmail.com>
	<alpine.LNX.2.00.1112191605280.2707@zbenl.fvgr>
	<20111219192504.GA32480@troutmask.apl.washington.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Brendan Fabeny <bf1783@gmail.com>, Mark Linimon <linimon@lonesome.com>,
	freebsd-ports@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>
Subject: Re: [PATCH] lang/gcc -- Fix build on freebsd-current
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2011 12:37:43 -0000

On Mon, 19 Dec 2011, Steve Kargl wrote:
> Not sure why you need confirmation before committing if it works for 
> you, because anything has to be better than the current state.

Well, I prefer not having to follow up with further patches later
(and luckily my full testing uncovered another small issue).

> Why?  Given that the typical build is 'make && make install && make clean',
> patching ChangeLog seems rather odd.  The same question applies to the
> other ChangeLog diffs that I've removed.

I was going for the full upstream changeset, consuming that directly.
Based on your feedback I just noted the upstream revision ids and omitted
the ChangeLog patches.

Thanks,
Gerald