From owner-cvs-usrsbin Sat Dec 6 09:50:42 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id JAA02619 for cvs-usrsbin-outgoing; Sat, 6 Dec 1997 09:50:42 -0800 (PST) (envelope-from owner-cvs-usrsbin) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id JAA02610; Sat, 6 Dec 1997 09:50:25 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id RAA25151; Sat, 6 Dec 1997 17:50:17 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.6/8.8.6) id SAA06765; Sat, 6 Dec 1997 18:49:55 +0100 (MET) To: Brian Somers Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/natd natd.c References: <199712061200.EAA01390@freefall.freebsd.org> From: Eivind Eklund Date: 06 Dec 1997 18:49:54 +0100 In-Reply-To: Brian Somers's message of Sat, 6 Dec 1997 04:00:37 -0800 (PST) Message-ID: <867m9i4b0d.fsf@bitbox.follo.net> Lines: 24 X-Mailer: Gnus v5.4.52/XEmacs 20.2 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Brian Somers writes: > brian 1997/12/06 04:00:35 PST > > Modified files: > usr.sbin/natd natd.c > Log: > Reverse my previous change and use htons() on an int > instead of htonl() ! > > This results in the int a,b,c,d changing to b,a,c,d, > but as it's subsequently coerced to a u_short, the > ultimate answer is correct. > > If this isn't fixed properly soon (by the author) I'll > have a look at it again. > > Noted by: eivind & ari@suutari.iki.fi Don't credit the messenger ;-) This was originally found by Aage Roebekk as noted in my original message (w/patch). Eivind.