From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 13:06:17 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6EBAE1065674 for ; Tue, 8 Feb 2011 13:06:17 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward15.mail.yandex.net (forward15.mail.yandex.net [95.108.130.119]) by mx1.freebsd.org (Postfix) with ESMTP id 202168FC1B for ; Tue, 8 Feb 2011 13:06:16 +0000 (UTC) Received: from smtp12.mail.yandex.net (smtp12.mail.yandex.net [95.108.131.191]) by forward15.mail.yandex.net (Yandex) with ESMTP id 07E9644588FF; Tue, 8 Feb 2011 16:06:16 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1297170376; bh=vEqow70Rh4wmXpliRt0rArKx0+6JS2uHb0HViuMGJh4=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=BT9D4jEjZtlaEjh7hjOGl5EpJDN5VjnHRNdVe9AX5nCD+P3xYReqK1Mmuu5RfxEF1 RKi+97WFfX83NkG0b0cU9VjyU9Yx2EoJKDOyZ3A8JO+sfo74t0OCuyNGRbeaoJVSEH qlUxSWeF+6NYQdimuHWDcxwRFgWuotA0jAtgDgIA= Received: from smeshariki2.local (unknown [213.27.65.65]) by smtp12.mail.yandex.net (Yandex) with ESMTPSA id AEEB55728077; Tue, 8 Feb 2011 16:06:15 +0300 (MSK) Message-ID: <4D513F7D.1040107@yandex.ru> Date: Tue, 08 Feb 2011 16:05:01 +0300 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU; rv:1.9.2.13) Gecko/20110106 Thunderbird/3.1.7 MIME-Version: 1.0 To: arrowdodger <6yearold@gmail.com> References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2011 13:06:17 -0000 Hi, 08.02.2011 14:40, arrowdodger пишет: > Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is > my first attempt in port creation, so i want someone to review it. > > The current problems are following: > 1. The user can choose to not install nautilus extension and translation > files (if defined(WITHOUT_NLS)). To prevent setup.py from installing those > stuff, i've made two patches, that resides in ${FILESDIR}. They are > generated from 'diff -u' and the problem is that they cannot be applied > together. If i generate patches with simply 'diff', then everythink works, > except that i should apply them manually (${PATCH} ${PYSETUP}< > ${FILESDIR}/no-locale.patch). > And what i've been told is that i should use EXTRA_PATCHES, insteand of > invoking patch. > > 2. The port also installs *.egg-info file and i'm not sure how to include it > in the plist. It shouldn't be listed in pkg-plist, because it will be removed automatically on port deinstall. > 3. The port also depends on py-gobject port, but there is no such value in > USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, that > it will be fixed after 8.2-RELEASE. > > You can obtain port from attachement or here: > http://intara.org.ru/tortoisehg.tar.gz > > Thanks in advance. dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's actually, because it's doesn't created by tortoisehg-hgtk, but nautilus or nautilus-plugins. Also consider to use: USE_GETTEXT= yes INSTALLS_ICONS= yes In port's Makefile. BLDDIR is defined but seems not used in Makefile. What it is for? -- Regards, Ruslan