From owner-freebsd-bugs@freebsd.org Tue Jan 17 01:29:30 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25717CB27E9 for ; Tue, 17 Jan 2017 01:29:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 152131A53 for ; Tue, 17 Jan 2017 01:29:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0H1TSRm016955 for ; Tue, 17 Jan 2017 01:29:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 216127] sbin/restore doesn't honour extended attributes (extattr on ufs) Date: Tue, 17 Jan 2017 01:29:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: cem@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 01:29:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216127 Conrad Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cem@freebsd.org Assignee|freebsd-bugs@FreeBSD.org |cem@freebsd.org --- Comment #1 from Conrad Meyer --- It appears that dump just dumps raw extattr data from UFS. The routine in restore responsible for parsing that raw data and turning it into syscalls = on the receiving filesystem is set_extattr_fd() in tape.c. The intent of the "system, (16 bytes), mb1946a (unable to set)" print is to print the namespace, extattr data length, and name of the extattr. The pro= blem appears to be that restore is using "%*s" rather than "%.*s" to print the non-null-terminated eap->ea_name. The former is the field width, while the latter is the precision. Only precision controls the number of characters printed by a %s format. The same naive behavior around non-null-terminated ea_name leads to the same bogus string being passed into extattr_set_fd() (or extattr_set_link, etc f= or the other variants) and used to check for ACL attributes. --=20 You are receiving this mail because: You are the assignee for the bug.=