From owner-freebsd-stable@FreeBSD.ORG Tue Jan 18 16:43:39 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3EF9106566C; Tue, 18 Jan 2011 16:43:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B4C0D8FC0A; Tue, 18 Jan 2011 16:43:39 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 5709946B1A; Tue, 18 Jan 2011 11:43:39 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5C8828A009; Tue, 18 Jan 2011 11:43:38 -0500 (EST) From: John Baldwin To: freebsd-stable@freebsd.org Date: Tue, 18 Jan 2011 11:19:41 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <4cfc72a5.3nAjkv8mdrO/NrKQ%perryh@pluto.rain.com> <4d3261bc.dcI6EuBnzRqvyRnz%perryh@pluto.rain.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201101181119.42053.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 18 Jan 2011 11:43:38 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-0.2 required=4.2 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Sergey Kandaurov , perryh@pluto.rain.com, avg@freebsd.org Subject: Re: Could MSGBUF_SIZE be made a loader tunable? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2011 16:43:40 -0000 On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote: > On 16 January 2011 06:10, wrote: > > Anyone had a chance to look at this? > > > > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/060793.html > > To ease testing on head I have regenerated the patch > (against r216594): > http://plukky.net/~pluknet/patches/msgbufsize.diff The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrelated. Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined and always assign it as the initial value rather than having an #ifdef. Finally, I would adjust the wording in the manpage to not say that this modifies the MSGBUF_SIZE option, but that this tunable is the same as adjusting MSGBUF_SIZE. Other than that I think it is fine. -- John Baldwin