From owner-p4-projects@FreeBSD.ORG  Sat Feb  2 09:08:45 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0CE0716A41A; Sat,  2 Feb 2008 09:08:45 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C66BA16A418
	for <perforce@freebsd.org>; Sat,  2 Feb 2008 09:08:44 +0000 (UTC)
	(envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 8143F13C459
	for <perforce@freebsd.org>; Sat,  2 Feb 2008 09:08:44 +0000 (UTC)
	(envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 6CBA241C74D;
	Sat,  2 Feb 2008 09:50:06 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id XFNK4UoHIxdK; Sat,  2 Feb 2008 09:50:05 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id E699F41C747; Sat,  2 Feb 2008 09:50:05 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 03C2044487F;
	Sat,  2 Feb 2008 08:47:58 +0000 (UTC)
Date: Sat, 2 Feb 2008 08:47:58 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: "Randall R. Stewart" <rrs@FreeBSD.org>
In-Reply-To: <200802020840.m128elSV080592@repoman.freebsd.org>
Message-ID: <20080202084735.E49429@maildrop.int.zabbadoz.net>
References: <200802020840.m128elSV080592@repoman.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 134645 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 09:08:45 -0000

On Sat, 2 Feb 2008, Randall R. Stewart wrote:

> http://perforce.freebsd.org/chv.cgi?CH=134645
>
> Change 134645 by rrs@rrs-mips2-jnpr on 2008/02/02 08:39:48
>
> 	Fix so Maxmem gets setup like it does in
> 	       other platforms. This really only fixes the Physmem print
> 	       before Avail Memory... but its one of those nags .
>
> Affected files ...
>
> .. //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#8 edit
>
> Differences ...
>
> ==== //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#8 (text+ko) ====
>
> @@ -1108,6 +1108,7 @@
> extern int	*end;
> extern void _start(void);
>
> +extern int Maxmem;
>
> static void
> mips_init(void)
> @@ -1190,6 +1191,8 @@
>         printf("\nBank 1 = 0x%8X   ->  0x%8X\n", phys_avail[2], phys_avail[3]);
>         printf("\nphysmem: 0x%lx", physmem);
>
> +	Maxmem = physmem;
> +


ist there a reason this variable starts with an uppercase letter?


> 	init_param1();
> 	init_param2(physmem);
> 	mips_cpu_init();
>

-- 
Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
Software is harder than hardware  so better get it right the first time.