From owner-freebsd-emulation@FreeBSD.ORG Mon Jan 28 18:58:29 2013 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 0DC6648F for ; Mon, 28 Jan 2013 18:58:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id E14D726B for ; Mon, 28 Jan 2013 18:58:28 +0000 (UTC) Received: from pakbsde14.localnet (unknown [38.105.238.108]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 46633B9BB; Mon, 28 Jan 2013 13:58:28 -0500 (EST) From: John Baldwin To: Chagin Dmitry Subject: Re: [PATCH] Move MI bits out of MD linux.h Date: Mon, 28 Jan 2013 13:53:36 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; ) References: <201301280947.39690.jhb@freebsd.org> <20130128174944.GA4105@dchagin.static.corbina.net> In-Reply-To: <20130128174944.GA4105@dchagin.static.corbina.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201301281353.36994.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 28 Jan 2013 13:58:28 -0500 (EST) Cc: emulation@freebsd.org X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 18:58:29 -0000 On Monday, January 28, 2013 12:49:44 pm Chagin Dmitry wrote: > On Mon, Jan 28, 2013 at 09:47:39AM -0500, John Baldwin wrote: > > This patch attempts to reduce duplication between i386/linux/linux.h and > > amd64/linux32/linux.h by moving bits that are MI out into headers in > > compat/linux. I only moved constants that were defined in MI headers in Linux > > itself, not necessarily all constants that have the same value. Further > > reduction could be possible if we wanted to make a linux-i386.h that these two > > headers could share, but that would be a separate project. > > > > http://www.FreeBSD.org/~jhb/patches/linux_mi.patch > > > > Hi, John! > Looks ok to me, furthemore I have similar patches in the local x86_64 linuxulator > repo. So, commit, please. So do you have an open PR with patches for the 64-bit linux stuff? I'd like to look at what you have and see about getting it into the tree if so. I'm curious about how you handled things (e.g. do you recompile things like linux_file.c twice once as 32-bit once as native, and do you have linux32.ko for the existing module and linux.ko for 64-bit)? -- John Baldwin