From owner-freebsd-multimedia@FreeBSD.ORG  Thu May 13 23:44:43 2010
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E16B1065673
	for <freebsd-multimedia@freebsd.org>;
	Thu, 13 May 2010 23:44:43 +0000 (UTC)
	(envelope-from wiz@danbala.tuwien.ac.at)
Received: from danbala.tuwien.ac.at (danbala.ifoer.tuwien.ac.at
	[128.130.168.64])
	by mx1.freebsd.org (Postfix) with ESMTP id EA3268FC13
	for <freebsd-multimedia@freebsd.org>;
	Thu, 13 May 2010 23:44:42 +0000 (UTC)
Received: by danbala.tuwien.ac.at (Postfix, from userid 116)
	id 79881390933; Fri, 14 May 2010 01:34:37 +0200 (MEST)
Date: Fri, 14 May 2010 01:34:37 +0200
From: Thomas Klausner <tk@giga.or.at>
To: freebsd-multimedia@freebsd.org
Message-ID: <20100513233437.GR27722@danbala.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Cc: edwin@mavetju.org
Subject: multimedia/pvr250 port doesn't compile on FreeBSD 8
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 May 2010 23:44:43 -0000

Hi!

Today I downloaded FreeBSD 8/amd64 and tried installing the pvr250
port.

It didn't compile, same reason as:
http://forums.freebsd.org/showthread.php?t=9852

The first error is in cxm_open; the code there is
	unit = UNIT( minor(dev) );
where unit is an int, and UNIT is defined as #define UNIT(x) ((x) & 0x0f)
but that's not the reason, since I get the same error when I just
remove the UNIT(...) and leave
	unit = minor(dev);

There's also the question of how the patch-iic target should be
handled on FreeBSD>6 (see forum page cited above).

Suggested patches?
 Thomas